Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigtable): modern Data API policy options #9320

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jun 21, 2022

Part of the work for #8860

I am going to release the modern Data API in pieces. Starting with the policies and their options. (Note that they are not used anywhere).

The root change is in options.h


This change is Reviewable

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jun 21, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 6388120c57bc3d2a78fb010ac115a0b00c79e55b

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #9320 (88a825f) into main (88a825f) will not change coverage.
The diff coverage is n/a.

❗ Current head 88a825f differs from pull request most recent head 6388120. Consider uploading reports for the commit 6388120 to get more accurate results

@@           Coverage Diff           @@
##             main    #9320   +/-   ##
=======================================
  Coverage   94.60%   94.60%           
=======================================
  Files        1470     1470           
  Lines      134686   134686           
=======================================
  Hits       127418   127418           
  Misses       7268     7268           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88a825f...6388120. Read the comment docs.

@dbolduc dbolduc marked this pull request as ready for review June 21, 2022 21:34
@dbolduc dbolduc requested a review from a team as a code owner June 21, 2022 21:34
@dbolduc dbolduc enabled auto-merge (squash) June 21, 2022 22:06
@dbolduc dbolduc merged commit ff90f3e into googleapis:main Jun 21, 2022
@dbolduc dbolduc deleted the bigtable-public-data-options branch July 20, 2022 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants