Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigtable): instance name as a class #9374

Merged
merged 3 commits into from
Jun 29, 2022

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jun 28, 2022

Part of the work for #9348

Plagiarized from: spanner/instance.h


This change is Reviewable

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jun 28, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: ea68ba1e8e77686639c60be9397ef1bf889dfba5

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #9374 (8f820a0) into main (f91081c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #9374   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files        1471     1474    +3     
  Lines      135321   135379   +58     
=======================================
+ Hits       128074   128131   +57     
- Misses       7247     7248    +1     
Impacted Files Coverage Δ
google/cloud/bigtable/instance_resource.cc 100.00% <100.00%> (ø)
google/cloud/bigtable/instance_resource.h 100.00% <100.00%> (ø)
google/cloud/bigtable/instance_resource_test.cc 100.00% <100.00%> (ø)
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 97.05% <0.00%> (-2.95%) ⬇️
google/cloud/pubsub/subscriber_connection_test.cc 97.22% <0.00%> (-0.70%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.00% <0.00%> (-0.25%) ⬇️
google/cloud/pubsub/samples/samples.cc 92.11% <0.00%> (-0.08%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 88.55% <0.00%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f91081c...8f820a0. Read the comment docs.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: e26fa03549d38fc4033717272c05ef6fd3fd1d73

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: c68ea6a0093bd111ecb26d64a6eb779a05b68c41

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@dbolduc dbolduc marked this pull request as ready for review June 28, 2022 22:53
@dbolduc dbolduc requested a review from a team as a code owner June 28, 2022 22:53
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small nit in the comments.

google/cloud/bigtable/instance_resource.h Outdated Show resolved Hide resolved
@dbolduc dbolduc enabled auto-merge (squash) June 29, 2022 05:44
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 8f820a052b7a7a1e92e4e387aa734ea8d3ee3d99

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@dbolduc dbolduc merged commit a5b052d into googleapis:main Jun 29, 2022
@dbolduc dbolduc deleted the bigtable-instance-class branch June 29, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants