Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GCS+gRPC): implement CreateNotification() #9639

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Aug 5, 2022

Fixes #4189


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 61726d113eb5a6a85ab939aeaa6fd75826679dab

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review August 5, 2022 20:50
@coryan coryan requested a review from a team as a code owner August 5, 2022 20:50
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #9639 (61726d1) into main (3b83b25) will increase coverage by 0.00%.
The diff coverage is 96.62%.

@@           Coverage Diff           @@
##             main    #9639   +/-   ##
=======================================
  Coverage   94.34%   94.35%           
=======================================
  Files        1490     1493    +3     
  Lines      138392   138479   +87     
=======================================
+ Hits       130571   130657   +86     
- Misses       7821     7822    +1     
Impacted Files Coverage Δ
...oogle/cloud/storage/internal/storage_round_robin.h 100.00% <ø> (ø)
google/cloud/storage/internal/grpc_client.cc 99.07% <83.33%> (-0.13%) ⬇️
...orage/internal/grpc_notification_request_parser.cc 83.33% <83.33%> (ø)
...rage/internal/grpc_notification_metadata_parser.cc 93.93% <85.71%> (-2.62%) ⬇️
google/cloud/storage/internal/grpc_client_test.cc 98.35% <100.00%> (+0.02%) ⬆️
.../internal/grpc_notification_request_parser_test.cc 100.00% <100.00%> (ø)
...ogle/cloud/storage/internal/storage_round_robin.cc 100.00% <100.00%> (ø)
...cloud/storage/internal/storage_round_robin_test.cc 99.78% <100.00%> (+<0.01%) ⬆️
google/cloud/storage/testing/mock_storage_stub.h 89.58% <100.00%> (+0.22%) ⬆️
...torage/tests/grpc_notification_integration_test.cc 100.00% <100.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@coryan coryan merged commit 19b2308 into googleapis:main Aug 5, 2022
@coryan coryan deleted the feat-GCS+gRPC-implement-CreateNotification branch August 5, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement storage::GrpcClient::CreateNotification
3 participants