Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(GCS+gRPC): remove struct GrpcOwnerParser #9837

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Sep 14, 2022

The struct was just serving as a namespace. This also starts the move of the GCS+gRPC implementation details to the storage_internal namespace.

Part of the work for #8929


This change is Reviewable

The struct was just serving as a namespace. This also starts the move
of the GCS+gRPC implementation details to the `storage_internal`
namespace.
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: a1aac9768a11e0ed366db82488bac41aff8d5643

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 94.24% // Head: 94.24% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (a1aac97) compared to base (0777ded).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9837      +/-   ##
==========================================
- Coverage   94.24%   94.24%   -0.01%     
==========================================
  Files        1495     1495              
  Lines      139834   139834              
==========================================
- Hits       131783   131780       -3     
- Misses       8051     8054       +3     
Impacted Files Coverage Δ
...ud/storage/internal/grpc_bucket_metadata_parser.cc 92.30% <100.00%> (ø)
...ud/storage/internal/grpc_object_metadata_parser.cc 97.19% <100.00%> (ø)
google/cloud/storage/internal/grpc_owner_parser.cc 83.33% <100.00%> (ø)
...e/cloud/storage/internal/grpc_owner_parser_test.cc 100.00% <100.00%> (ø)
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 97.05% <0.00%> (-2.95%) ⬇️
...bigtable/examples/bigtable_hello_instance_admin.cc 81.00% <0.00%> (-2.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review September 14, 2022 15:33
@coryan coryan requested a review from a team as a code owner September 14, 2022 15:33
@coryan coryan merged commit aceeb50 into googleapis:main Sep 14, 2022
@coryan coryan deleted the cleanup-GCS+gRPC-use-standalone-functions branch September 14, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants