Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(GCS+gRPC): Notification helpers to storage_internal #9867

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Sep 16, 2022

Part of the work for #8929.

But mostly a small PR to make sure my Kokoro configuration changes did not break anything.


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 48969faf9dab917a605d9372d83ac295d304e688

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 94.24% // Head: 94.24% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (48969fa) compared to base (d840a74).
Patch coverage: 88.46% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9867      +/-   ##
==========================================
- Coverage   94.24%   94.24%   -0.01%     
==========================================
  Files        1495     1495              
  Lines      139838   139838              
==========================================
- Hits       131788   131785       -3     
- Misses       8050     8053       +3     
Impacted Files Coverage Δ
...internal/grpc_notification_metadata_parser_test.cc 100.00% <ø> (ø)
google/cloud/storage/internal/grpc_client.cc 98.75% <57.14%> (ø)
...rage/internal/grpc_notification_metadata_parser.cc 93.93% <100.00%> (ø)
...orage/internal/grpc_notification_request_parser.cc 82.75% <100.00%> (ø)
.../internal/grpc_notification_request_parser_test.cc 100.00% <100.00%> (ø)
...integration_tests/schema_admin_integration_test.cc 98.88% <0.00%> (-1.12%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.82% <0.00%> (-0.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review September 16, 2022 17:07
@coryan coryan requested a review from a team as a code owner September 16, 2022 17:07
@coryan coryan merged commit 659fe70 into googleapis:main Sep 16, 2022
@coryan coryan deleted the cleanup-GCS+gRPC-notification-helpers-to-storage-internal branch September 16, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants