Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storage): move ProjectTeam to a public header #9906

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Sep 23, 2022

Part of the work for #8929


This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Sep 23, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 714d034a82386a260cc8d18420dcf83bc3fb60bd

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Base: 94.20% // Head: 94.20% // No change to project coverage 👍

Coverage data is based on head (714d034) compared to base (f6e9229).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9906   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files        1494     1495    +1     
  Lines      140166   140166           
=======================================
  Hits       132042   132042           
  Misses       8124     8124           
Impacted Files Coverage Δ
...gle/cloud/storage/internal/access_control_common.h 100.00% <ø> (ø)
google/cloud/storage/project_team.h 100.00% <100.00%> (ø)
...cloud/pubsub/internal/subscription_session_test.cc 97.82% <0.00%> (-0.68%) ⬇️
google/cloud/pubsub/subscriber_connection_test.cc 98.31% <0.00%> (+0.56%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.00% <0.00%> (+2.00%) ⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review September 23, 2022 18:43
@coryan coryan requested a review from a team as a code owner September 23, 2022 18:43
@coryan coryan merged commit 52b8433 into googleapis:main Sep 23, 2022
@coryan coryan deleted the refactor-storage-move-project-team branch September 23, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants