Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(GCS+gRPC): move SignBlob request helpers #9962

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Sep 30, 2022

Despite the branch name, this is only part of the work for #8929


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 3258bb9c1739c9e1061d6022dec25127b06d7a8f

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review September 30, 2022 22:49
@coryan coryan requested a review from a team as a code owner September 30, 2022 22:49
@coryan coryan enabled auto-merge (squash) September 30, 2022 22:49
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 94.21% // Head: 94.21% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (3258bb9) compared to base (d25d981).
Patch coverage: 90.90% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9962   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files        1497     1497           
  Lines      140499   140500    +1     
=======================================
+ Hits       132373   132374    +1     
  Misses       8126     8126           
Impacted Files Coverage Δ
google/cloud/storage/internal/grpc_client.cc 98.75% <50.00%> (ø)
.../storage/internal/grpc_sign_blob_request_parser.cc 93.33% <100.00%> (ø)
...age/internal/grpc_sign_blob_request_parser_test.cc 100.00% <100.00%> (ø)
...cloud/pubsub/internal/subscription_session_test.cc 97.82% <0.00%> (-0.34%) ⬇️
google/cloud/storage/parallel_upload.cc 98.61% <0.00%> (+0.34%) ⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan merged commit 058887b into googleapis:main Sep 30, 2022
@coryan coryan deleted the cleanup-GCS+gRPC-complete-move-to-storage-internal branch October 1, 2022 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants