docs: Document thread starvation scenario workaround. #11142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskeet
reviewed
Oct 5, 2023
| @@ -82,76 +82,6 @@ restart listening for messages with `StartAsync(...)` again. Due to the expense | |||
| instance, it is recommended that a singleton client per topic is used for the lifetime of the | |||
| application. | |||
|
|
|||
| ## Dependency Injection | |||
There was a problem hiding this comment.
I'm not sure about this - the AddSubscriberClient and AddPublisherClient methods do have slightly different overloads to the pure-GAPIC ones. I suspect we don't need as much detail as we currently have, but I think some is important - including the aspects about automatic stopping.
There was a problem hiding this comment.
Yes, OK, I'll split this PR in two and reinstate some of the Pub/Sub specific docs.
| @@ -101,6 +101,28 @@ builder.Services | |||
| .AddExampleClient(); | |||
| ``` | |||
|
|
|||
| #### Dependency injection in high-load-at-startup environments. | |||
|
|
|||
| If your application uses Application Default Credentials while running in a Google runtime (Compute, | |||
There was a problem hiding this comment.
Compute Engine instead of just Compute?
| builder.Services | ||
| .AddRazorPages() | ||
| .AddExampleClient(); | ||
| // Workarounf for possible thread starvation scenario. |
amanda-tarafa
commented
Oct 5, 2023
| @@ -82,76 +82,6 @@ restart listening for messages with `StartAsync(...)` again. Due to the expense | |||
| instance, it is recommended that a singleton client per topic is used for the lifetime of the | |||
| application. | |||
|
|
|||
| ## Dependency Injection | |||
There was a problem hiding this comment.
Yes, OK, I'll split this PR in two and reinstate some of the Pub/Sub specific docs.
| @@ -101,6 +101,28 @@ builder.Services | |||
| .AddExampleClient(); | |||
| ``` | |||
|
|
|||
| #### Dependency injection in high-load-at-startup environments. | |||
|
|
|||
| If your application uses Application Default Credentials while running in a Google runtime (Compute, | |||
| builder.Services | ||
| .AddRazorPages() | ||
| .AddExampleClient(); | ||
| // Workarounf for possible thread starvation scenario. |
jskeet
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #11092