Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [Google.Cloud.Spanner.V1] protos for R/W transaction support on multiplexed sessions #13674

Merged
merged 1 commit into from
Oct 9, 2024
Merged

chore: [Google.Cloud.Spanner.V1] protos for R/W transaction support on multiplexed sessions #13674

merged 1 commit into from
Oct 9, 2024

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Oct 9, 2024

  • Regenerate this pull request now.

PiperOrigin-RevId: 683879049

Source-Link: googleapis/googleapis@2b6b93b

Source-Link: https://github.com/googleapis/googleapis-gen/commit/2f0c933b003164d5cd120505a98c87c95888d98f
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuU3Bhbm5lci5WMS8uT3dsQm90LnlhbWwiLCJoIjoiMmYwYzkzM2IwMDMxNjRkNWNkMTIwNTA1YTk4Yzg3Yzk1ODg4ZDk4ZiJ9

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

Pull request diff results
OwlBot post-processor has not run: failing diff.

@gcf-owl-bot
chore: protos for R/W transaction support on multiplexed sessions
c019ca6 
PiperOrigin-RevId: 683879049

Source-Link: googleapis/googleapis@2b6b93b

Source-Link: googleapis/googleapis-gen@2f0c933
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuU3Bhbm5lci5WMS8uT3dsQm90LnlhbWwiLCJoIjoiMmYwYzkzM2IwMDMxNjRkNWNkMTIwNTA1YTk4Yzg3Yzk1ODg4ZDk4ZiJ9
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review October 9, 2024 09:09
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner October 9, 2024 09:09
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-apis-Google_Cloud_Spanner_V1 branch from 550d06e to c019ca6 Compare October 9, 2024 09:09
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

Pull request diff results
Finding changes in Google.Cloud.Spanner.V1...
Comparing old and new versions (by source)
Minor changes:
Class 'BeginTransactionRequest'; property 'Mutation MutationKey { get; set; }' added.
Class 'BeginTransactionRequest'; constant 'System.Int32 Google.Cloud.Spanner.V1.BeginTransactionRequest::MutationKeyFieldNumber' added.
Class 'CommitRequest'; property 'MultiplexedSessionPrecommitToken PrecommitToken { get; set; }' added.
Class 'CommitRequest'; constant 'System.Int32 Google.Cloud.Spanner.V1.CommitRequest::PrecommitTokenFieldNumber' added.
Class 'CommitResponse'; method 'void ClearMultiplexedSessionRetry()' added.
Class 'CommitResponse'; property 'CommitResponse.MultiplexedSessionRetryOneofCase MultiplexedSessionRetryCase { get; }' added.
Class 'CommitResponse'; property 'MultiplexedSessionPrecommitToken PrecommitToken { get; set; }' added.
Class 'CommitResponse'; constant 'System.Int32 Google.Cloud.Spanner.V1.CommitResponse::PrecommitTokenFieldNumber' added.
Enum 'CommitResponse.MultiplexedSessionRetryOneofCase' added.
Class 'ExecuteBatchDmlResponse'; property 'MultiplexedSessionPrecommitToken PrecommitToken { get; set; }' added.
Class 'ExecuteBatchDmlResponse'; constant 'System.Int32 Google.Cloud.Spanner.V1.ExecuteBatchDmlResponse::PrecommitTokenFieldNumber' added.
Class 'MultiplexedSessionPrecommitToken' added.
Class 'PartialResultSet'; property 'MultiplexedSessionPrecommitToken PrecommitToken { get; set; }' added.
Class 'PartialResultSet'; constant 'System.Int32 Google.Cloud.Spanner.V1.PartialResultSet::PrecommitTokenFieldNumber' added.
Class 'ResultSet'; property 'MultiplexedSessionPrecommitToken PrecommitToken { get; set; }' added.
Class 'ResultSet'; constant 'System.Int32 Google.Cloud.Spanner.V1.ResultSet::PrecommitTokenFieldNumber' added.
Class 'Transaction'; property 'MultiplexedSessionPrecommitToken PrecommitToken { get; set; }' added.
Class 'Transaction'; constant 'System.Int32 Google.Cloud.Spanner.V1.Transaction::PrecommitTokenFieldNumber' added.
Class 'TransactionOptions.Types.ReadWrite'; property 'ByteString MultiplexedSessionPreviousTransactionId { get; set; }' added.
Class 'TransactionOptions.Types.ReadWrite'; constant 'System.Int32 Google.Cloud.Spanner.V1.TransactionOptions/Types/ReadWrite::MultiplexedSessionPreviousTransactionIdFieldNumber' added.

Diff level: Minor

Comparing with previous NuGet package
Checking compatibility for Google.Cloud.Spanner.V1 version 5.0.0-beta04
Differences from 4.6.0
Major changes:
Class 'PooledSession'; method 'Task WithFreshTransactionOrNewAsync(TransactionOptions transactionOptions, CancellationToken cancellationToken)' removed.
Class 'PooledSession'; method 'void DetachFromPool()' removed.
Class 'SessionPool'; method 'SessionPool.DatabaseStatistics GetStatisticsSnapshot(DatabaseName databaseName)' removed.
Class 'SessionPool.DatabaseStatistics' removed.
Class 'SessionPool.SessionPoolSegmentStatistics'; property 'Int32 ReadPoolCount { get; }' removed.
Class 'SessionPool.SessionPoolSegmentStatistics'; property 'Int32 ReadWritePoolCount { get; }' removed.
Class 'SessionPool.SessionPoolSegmentStatistics'; property 'Int64 ReadWriteTransactionRequests { get; }' removed.
Class 'SessionPool.SessionPoolSegmentStatistics'; property 'Int64 ReadWriteTransactionRequestsPrewarmed { get; }' removed.
Class 'SessionPool.Statistics'; property 'IReadOnlyList<SessionPool.DatabaseStatistics> PerDatabaseStatistics { get; }' removed.
Class 'SessionPool.Statistics'; property 'Int32 TotalReadPoolCount { get; }' removed.
Class 'SessionPool.Statistics'; property 'Int32 TotalReadWritePoolCount { get; }' removed.
Class 'SessionPoolOptions'; property 'Double WriteSessionsFraction { get; set; }' removed.

Minor changes:
Class 'BatchWriteRequest' added.
Class 'BatchWriteRequest.Types' added.
Class 'BatchWriteRequest.Types.MutationGroup' added.
Class 'BatchWriteResponse' added.
Class 'BeginTransactionRequest'; property 'Mutation MutationKey { get; set; }' added.
Class 'BeginTransactionRequest'; constant 'System.Int32 Google.Cloud.Spanner.V1.BeginTransactionRequest::MutationKeyFieldNumber' added.
Class 'CommitRequest'; property 'MultiplexedSessionPrecommitToken PrecommitToken { get; set; }' added.
Class 'CommitRequest'; property 'Duration MaxCommitDelay { get; set; }' added.
Class 'CommitRequest'; constant 'System.Int32 Google.Cloud.Spanner.V1.CommitRequest::MaxCommitDelayFieldNumber' added.
Class 'CommitRequest'; constant 'System.Int32 Google.Cloud.Spanner.V1.CommitRequest::PrecommitTokenFieldNumber' added.
Class 'CommitResponse'; method 'void ClearMultiplexedSessionRetry()' added.
Class 'CommitResponse'; property 'CommitResponse.MultiplexedSessionRetryOneofCase MultiplexedSessionRetryCase { get; }' added.
Class 'CommitResponse'; property 'MultiplexedSessionPrecommitToken PrecommitToken { get; set; }' added.
Class 'CommitResponse'; constant 'System.Int32 Google.Cloud.Spanner.V1.CommitResponse::PrecommitTokenFieldNumber' added.
Enum 'CommitResponse.MultiplexedSessionRetryOneofCase' added.
Class 'DirectedReadOptions' added.
Enum 'DirectedReadOptions.ReplicasOneofCase' added.
Class 'DirectedReadOptions.Types' added.
Class 'DirectedReadOptions.Types.ExcludeReplicas' added.
Class 'DirectedReadOptions.Types.IncludeReplicas' added.
Class 'DirectedReadOptions.Types.ReplicaSelection' added.
Class 'DirectedReadOptions.Types.ReplicaSelection.Types' added.
Enum 'DirectedReadOptions.Types.ReplicaSelection.Types.Type' added.
Class 'ExecuteBatchDmlResponse'; property 'MultiplexedSessionPrecommitToken PrecommitToken { get; set; }' added.
Class 'ExecuteBatchDmlResponse'; constant 'System.Int32 Google.Cloud.Spanner.V1.ExecuteBatchDmlResponse::PrecommitTokenFieldNumber' added.
Class 'ExecuteSqlRequest'; property 'DirectedReadOptions DirectedReadOptions { get; set; }' added.
Class 'ExecuteSqlRequest'; property 'TransactionSelector Transaction { get; set; }' modifers changed from '' to 'sealed virtual'.
Class 'ExecuteSqlRequest'; constant 'System.Int32 Google.Cloud.Spanner.V1.ExecuteSqlRequest::DirectedReadOptionsFieldNumber' added.
Enum 'ExecuteSqlRequest.Types.QueryMode' entry 'WithStats' added.
Enum 'ExecuteSqlRequest.Types.QueryMode' entry 'WithPlanAndStats' added.
Class 'MultiplexedSessionPrecommitToken' added.
Class 'PartialResultSet'; property 'MultiplexedSessionPrecommitToken PrecommitToken { get; set; }' added.
Class 'PartialResultSet'; constant 'System.Int32 Google.Cloud.Spanner.V1.PartialResultSet::PrecommitTokenFieldNumber' added.
Class 'PartitionQueryRequest'; property 'TransactionSelector Transaction { get; set; }' modifers changed from '' to 'sealed virtual'.
Class 'PartitionReadOrQueryRequest'; property 'TransactionSelector Transaction { set; }' getter access modifer changed from '' to 'public'.
Class 'PartitionReadRequest'; property 'TransactionSelector Transaction { get; set; }' modifers changed from '' to 'sealed virtual'.
Class 'PooledSession'; method 'Task RefreshedOrNewAsync(CancellationToken cancellationToken)' added.
Class 'PooledSession'; property 'Boolean IsDetached { get; }' added.
Class 'ReadOrQueryRequest'; property 'DirectedReadOptions DirectedReadOptions { get; set; }' added.
Class 'ReadOrQueryRequest'; property 'TransactionSelector Transaction { set; }' getter access modifer changed from '' to 'public'.
Class 'ReadRequest'; property 'DirectedReadOptions DirectedReadOptions { get; set; }' added.
Class 'ReadRequest'; property 'ReadRequest.Types.LockHint LockHint { get; set; }' added.
Class 'ReadRequest'; property 'ReadRequest.Types.OrderBy OrderBy { get; set; }' added.
Class 'ReadRequest'; property 'TransactionSelector Transaction { get; set; }' modifers changed from '' to 'sealed virtual'.
Class 'ReadRequest'; constant 'System.Int32 Google.Cloud.Spanner.V1.ReadRequest::DirectedReadOptionsFieldNumber' added.
Class 'ReadRequest'; constant 'System.Int32 Google.Cloud.Spanner.V1.ReadRequest::LockHintFieldNumber' added.
Class 'ReadRequest'; constant 'System.Int32 Google.Cloud.Spanner.V1.ReadRequest::OrderByFieldNumber' added.
Class 'ReadRequest.Types' added.
Enum 'ReadRequest.Types.LockHint' added.
Enum 'ReadRequest.Types.OrderBy' added.
Class 'ResultSet'; property 'MultiplexedSessionPrecommitToken PrecommitToken { get; set; }' added.
Class 'ResultSet'; constant 'System.Int32 Google.Cloud.Spanner.V1.ResultSet::PrecommitTokenFieldNumber' added.
Class 'Session'; property 'Boolean Multiplexed { get; set; }' added.
Class 'Session'; constant 'System.Int32 Google.Cloud.Spanner.V1.Session::MultiplexedFieldNumber' added.
Class 'SessionPool'; method 'Task AcquireDetachedSessionAsync(SessionPool.SessionPoolSegmentKey key, TransactionOptions transactionOptions, Boolean singleUseTransaction, CancellationToken cancellationToken)' added.
Class 'SessionPool'; method 'Task AcquireSessionAsync(SessionPool.SessionPoolSegmentKey key, TransactionOptions transactionOptions, Boolean singleUseTransaction, CancellationToken cancellationToken)' added.
Class 'SessionPool.SessionPoolSegmentStatistics'; property 'Int32 PoolCount { get; }' added.
Class 'SessionPool.Statistics'; property 'Int32 TotalPoolCount { get; }' added.
Class 'Spanner.SpannerBase'; method 'Task BatchWrite(BatchWriteRequest request, IServerStreamWriter responseStream, ServerCallContext context)' added.
Class 'Spanner.SpannerClient'; method 'AsyncServerStreamingCall BatchWrite(BatchWriteRequest request, CallOptions options)' added.
Class 'Spanner.SpannerClient'; method 'AsyncServerStreamingCall BatchWrite(BatchWriteRequest request, Metadata headers = null, Nullable deadline = null, CancellationToken cancellationToken = null)' added.
Class 'SpannerClient'; method 'SpannerClient.BatchWriteStream BatchWrite(BatchWriteRequest request, CallSettings callSettings = null)' added.
Class 'SpannerClient'; method 'SpannerClient.BatchWriteStream BatchWrite(SessionName session, IEnumerable<BatchWriteRequest.Types.MutationGroup> mutationGroups, CallSettings callSettings = null)' added.
Class 'SpannerClient'; method 'SpannerClient.BatchWriteStream BatchWrite(String session, IEnumerable<BatchWriteRequest.Types.MutationGroup> mutationGroups, CallSettings callSettings = null)' added.
Class 'SpannerClient.BatchWriteStream' added.
Class 'SpannerClientBuilder'; property 'DirectedReadOptions DirectedReadOptions { get; set; }' added.
Class 'SpannerClientBuilder'; property 'Boolean LeaderRoutingEnabled { get; set; }' added.
Class 'SpannerClientImpl'; method 'SpannerClient.BatchWriteStream BatchWrite(BatchWriteRequest request, CallSettings callSettings = null)' added.
Class 'SpannerSettings'; property 'CallSettings BatchWriteSettings { get; set; }' added.
Class 'Transaction'; property 'MultiplexedSessionPrecommitToken PrecommitToken { get; set; }' added.
Class 'Transaction'; constant 'System.Int32 Google.Cloud.Spanner.V1.Transaction::PrecommitTokenFieldNumber' added.
Class 'TransactionOptions'; property 'Boolean ExcludeTxnFromChangeStreams { get; set; }' added.
Class 'TransactionOptions'; constant 'System.Int32 Google.Cloud.Spanner.V1.TransactionOptions::ExcludeTxnFromChangeStreamsFieldNumber' added.
Class 'TransactionOptions.Types.ReadWrite'; property 'ByteString MultiplexedSessionPreviousTransactionId { get; set; }' added.
Class 'TransactionOptions.Types.ReadWrite'; constant 'System.Int32 Google.Cloud.Spanner.V1.TransactionOptions/Types/ReadWrite::MultiplexedSessionPreviousTransactionIdFieldNumber' added.
Class 'Type'; property 'String ProtoTypeFqn { get; set; }' added.
Class 'Type'; constant 'System.Int32 Google.Cloud.Spanner.V1.Type::ProtoTypeFqnFieldNumber' added.
Enum 'TypeAnnotationCode' entry 'PgOid' added.
Enum 'TypeCode' entry 'Float32' added.
Enum 'TypeCode' entry 'Proto' added.
Enum 'TypeCode' entry 'Enum' added.
Enum 'TypeCode' entry 'Interval' added.
Class 'ServiceCollectionExtensions'; method 'IServiceCollection AddSpannerClient(IServiceCollection services, Action<IServiceProvider, SpannerClientBuilder> action)' added.

Diff level: Major

Differences from 5.0.0-beta04
Minor changes:
Class 'BeginTransactionRequest'; property 'Mutation MutationKey { get; set; }' added.
Class 'BeginTransactionRequest'; constant 'System.Int32 Google.Cloud.Spanner.V1.BeginTransactionRequest::MutationKeyFieldNumber' added.
Class 'CommitRequest'; property 'MultiplexedSessionPrecommitToken PrecommitToken { get; set; }' added.
Class 'CommitRequest'; constant 'System.Int32 Google.Cloud.Spanner.V1.CommitRequest::PrecommitTokenFieldNumber' added.
Class 'CommitResponse'; method 'void ClearMultiplexedSessionRetry()' added.
Class 'CommitResponse'; property 'CommitResponse.MultiplexedSessionRetryOneofCase MultiplexedSessionRetryCase { get; }' added.
Class 'CommitResponse'; property 'MultiplexedSessionPrecommitToken PrecommitToken { get; set; }' added.
Class 'CommitResponse'; constant 'System.Int32 Google.Cloud.Spanner.V1.CommitResponse::PrecommitTokenFieldNumber' added.
Enum 'CommitResponse.MultiplexedSessionRetryOneofCase' added.
Class 'ExecuteBatchDmlResponse'; property 'MultiplexedSessionPrecommitToken PrecommitToken { get; set; }' added.
Class 'ExecuteBatchDmlResponse'; constant 'System.Int32 Google.Cloud.Spanner.V1.ExecuteBatchDmlResponse::PrecommitTokenFieldNumber' added.
Enum 'ExecuteSqlRequest.Types.QueryMode' entry 'WithStats' added.
Enum 'ExecuteSqlRequest.Types.QueryMode' entry 'WithPlanAndStats' added.
Class 'MultiplexedSessionPrecommitToken' added.
Class 'PartialResultSet'; property 'MultiplexedSessionPrecommitToken PrecommitToken { get; set; }' added.
Class 'PartialResultSet'; constant 'System.Int32 Google.Cloud.Spanner.V1.PartialResultSet::PrecommitTokenFieldNumber' added.
Class 'ResultSet'; property 'MultiplexedSessionPrecommitToken PrecommitToken { get; set; }' added.
Class 'ResultSet'; constant 'System.Int32 Google.Cloud.Spanner.V1.ResultSet::PrecommitTokenFieldNumber' added.
Class 'Transaction'; property 'MultiplexedSessionPrecommitToken PrecommitToken { get; set; }' added.
Class 'Transaction'; constant 'System.Int32 Google.Cloud.Spanner.V1.Transaction::PrecommitTokenFieldNumber' added.
Class 'TransactionOptions.Types.ReadWrite'; property 'ByteString MultiplexedSessionPreviousTransactionId { get; set; }' added.
Class 'TransactionOptions.Types.ReadWrite'; constant 'System.Int32 Google.Cloud.Spanner.V1.TransactionOptions/Types/ReadWrite::MultiplexedSessionPreviousTransactionIdFieldNumber' added.
Enum 'TypeCode' entry 'Interval' added.

Diff level: Minor

Finished comparisons for Google.Cloud.Spanner.V1

@jskeet jskeet merged commit 2c001a6 into main Oct 9, 2024
13 checks passed
@jskeet jskeet deleted the owl-bot-copy-apis-Google_Cloud_Spanner_V1 branch October 9, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

Assignees
No one assigned
Labels
kokoro:force-run Add this label to force Kokoro to re-run the tests. owl-bot-copy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jskeet