Merge branch 'main' into prototype_grpc_dp_removal

auth/auth.go

@@ -12,6 +12,11 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// Package auth provides utilities for managing Google Cloud credentials,
+// including functionality for creating, caching, and refreshing OAuth2 tokens.
+// It offers customizable options for different OAuth2 flows, such as 2-legged
+// (2LO) and 3-legged (3LO) OAuth, along with support for PKCE and automatic
+// token management.
 package auth
 
 import (

auth/credentials/idtoken/idtoken.go

@@ -12,6 +12,12 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// Package idtoken provides functionality for generating and validating ID
+// tokens, with configurable options for audience, custom claims, and token
+// formats.
+//
+// For more information on ID tokens, see
+// https://cloud.google.com/docs/authentication/token-types#id.
 package idtoken
 
 import (

auth/grpctransport/grpctransport.go

@@ -12,6 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// Package grpctransport provides functionality for managing gRPC client
+// connections to Google Cloud services.
 package grpctransport
 
 import (

auth/httptransport/httptransport.go

@@ -12,6 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// Package httptransport provides functionality for managing HTTP client
+// connections to Google Cloud services.
 package httptransport
 
 import (

bigtable/bigtable.go

@@ -396,8 +396,10 @@ func (t *Table) readRows(ctx context.Context, arg RowSet, f func(Row) bool, mt *
 		// Ignore error since header is only being used to record builtin metrics
 		// Failure to record metrics should not fail the operation
 		*headerMD, _ = stream.Header()
+		res := new(btpb.ReadRowsResponse)
 		for {
-			res, err := stream.Recv()
+			proto.Reset(res)
+			err := stream.RecvMsg(res)
 			if err == io.EOF {
 				*trailerMD = stream.Trailer()
 				break
@@ -438,7 +440,8 @@ func (t *Table) readRows(ctx context.Context, arg RowSet, f func(Row) bool, mt *
 					// Cancel and drain stream.
 					cancel()
 					for {
-						if _, err := stream.Recv(); err != nil {
+						proto.Reset(res)
+						if err := stream.RecvMsg(res); err != nil {
 							*trailerMD = stream.Trailer()
 							// The stream has ended. We don't return an error
 							// because the caller has intentionally interrupted the scan.

bigtable/integration_test.go

@@ -347,10 +347,7 @@ func TestIntegration_Aggregates(t *testing.T) {
 		t.Fatalf("Read row mismatch.\n got %#v\nwant %#v", row, wantRow)
 	}
 
-	err = ac.UpdateFamily(ctx, tableName, family, Family{ValueType: AggregateType{
-		Input:      Int64Type{},
-		Aggregator: MinAggregator{},
-	}})
+	err = ac.UpdateFamily(ctx, tableName, family, Family{ValueType: Int64Type{}})
 	if err == nil {
 		t.Fatalf("Expected UpdateFamily to fail, but it didn't")
 	}

firestore/integration_test.go

@@ -2521,7 +2521,7 @@ func TestIntegration_AggregationQueries(t *testing.T) {
 
 	indexFields := [][]string{
 		{"weight", "model"},
-		{"weight", "height"},
+		{"weight", "volume"},
 	}
 	adminCtx, cancel := context.WithTimeout(context.Background(), 15*time.Minute)
 	defer cancel()
@@ -2530,14 +2530,14 @@ func TestIntegration_AggregationQueries(t *testing.T) {
 
 	h := testHelper{t}
 	docs := []map[string]interface{}{
-		{"weight": 1.5, "height": 99, "model": "A"},
-		{"weight": 2.6, "height": 98, "model": "A"},
-		{"weight": 3.7, "height": 97, "model": "B"},
-		{"weight": 4.8, "height": 96, "model": "B"},
-		{"weight": 5.9, "height": 95, "model": "C"},
-		{"weight": 6.0, "height": 94, "model": "B"},
-		{"weight": 7.1, "height": 93, "model": "C"},
-		{"weight": 8.2, "height": 93, "model": "A"},
+		{"weight": 1.5, "volume": 99, "model": "A"},
+		{"weight": 2.6, "volume": 98, "model": "A"},
+		{"weight": 3.7, "volume": 97, "model": "B"},
+		{"weight": 4.8, "volume": 96, "model": "B"},
+		{"weight": 5.9, "volume": 95, "model": "C"},
+		{"weight": 6.0, "volume": 94, "model": "B"},
+		{"weight": 7.1, "volume": 93, "model": "C"},
+		{"weight": 8.2, "volume": 93, "model": "A"},
 	}
 	docRefs := []*DocumentRef{}
 	for _, doc := range docs {
@@ -2572,7 +2572,7 @@ func TestIntegration_AggregationQueries(t *testing.T) {
 	}{
 		{
 			desc:             "Multiple aggregations",
-			aggregationQuery: query.NewAggregationQuery().WithCount("count1").WithAvg("weight", "weight_avg1").WithAvg("height", "height_avg1").WithSum("weight", "weight_sum1").WithSum("height", "height_sum1"),
+			aggregationQuery: query.NewAggregationQuery().WithCount("count1").WithAvg("weight", "weight_avg1").WithAvg("volume", "height_avg1").WithSum("weight", "weight_sum1").WithSum("volume", "height_sum1"),
 			wantErr:          false,
 			result: map[string]interface{}{
 				"count1":      &pb.Value{ValueType: &pb.Value_IntegerValue{IntegerValue: int64(8)}},
@@ -2584,7 +2584,7 @@ func TestIntegration_AggregationQueries(t *testing.T) {
 		},
 		{
 			desc:             "Aggregations in transaction",
-			aggregationQuery: query.NewAggregationQuery().WithCount("count1").WithAvg("weight", "weight_avg1").WithAvg("height", "height_avg1").WithSum("weight", "weight_sum1").WithSum("height", "height_sum1"),
+			aggregationQuery: query.NewAggregationQuery().WithCount("count1").WithAvg("weight", "weight_avg1").WithAvg("volume", "height_avg1").WithSum("weight", "weight_sum1").WithSum("volume", "height_sum1"),
 			wantErr:          false,
 			runInTransaction: true,
 			result: map[string]interface{}{