Skip to content

Commit

Permalink
revert line removals
Browse files Browse the repository at this point in the history
  • Loading branch information
frankyn committed Aug 28, 2024
1 parent 83bb31b commit 75e8f6b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions storage/grpc_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ func newGRPCStorageClient(ctx context.Context, opts ...storageOption) (storageCl
if config.readAPIWasSet {
return nil, errors.New("storage: GRPC is incompatible with any option that specifies an API for reads")
}

// Metrics requires the endpoint before GAPIC is created which is only available in connPool after GAPIC is created.
// Seperated initialization of pool beforehand and passing the instance to
// the GAPIC client.
Expand Down Expand Up @@ -166,6 +167,7 @@ func newGRPCStorageClient(ctx context.Context, opts ...storageOption) (storageCl
if err != nil {
return nil, err
}

return &grpcStorageClient{
raw: g,
settings: s,
Expand Down
1 change: 1 addition & 0 deletions storage/storage.go
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ func NewGRPCClient(ctx context.Context, opts ...option.ClientOption) (*Client, e
if err != nil {
return nil, err
}

return &Client{tc: tc}, nil
}

Expand Down

0 comments on commit 75e8f6b

Please sign in to comment.