-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
civil: support sql.Scanner and driver.Valuer #1145
Comments
Just to clarify: are you using |
I'm using it with an SQL system outside this repo. I don't really know what will happen with golang/go#19700 (and whether whatever is added looks like this type), but for the time being If it's not intended for this package to be used more widely, please let me know :-) Scanner/Valuer seem pretty common on basic types like this, and are very useful. |
@bradfitz thoughts? |
Seems reasonable. |
FYI I have a PR in progress, just need to add testing. |
We don't accept GitHub PRs; we use Gerrit. See CONTRIBUTING.md. But if you put up a PR, I will make a Gerrit CL for you. |
cc @shollyman |
@tbpg would you be able to help us route this issue to the right place? @olavloite and I were looking at this and it doesn't seem like this is related to spanner. |
Spanner and BigQuery are the two importers of the |
From my understanding of this issue, I think the intention is to add sql.Scanner and driver.Valuer support in https://github.com/googleapis/google-cloud-go/blob/master/civil/civil.go. I'm not sure who in the Go team maintains that package at the moment. So I might leave it up to the Go team to assign this to the right person. |
Closing due to no traction on this in the last 4ish years |
It would be great if e.g. civil.Date was directly usable in SQL queries.
The text was updated successfully, but these errors were encountered: