Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

civil: helpers to work with dates: Range, Min, Max? #1755

Closed
evanj opened this issue Jan 28, 2020 · 2 comments
Closed

civil: helpers to work with dates: Range, Min, Max? #1755

evanj opened this issue Jan 28, 2020 · 2 comments
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@evanj
Copy link

evanj commented Jan 28, 2020

I'm writing some Go programs that coordinate a bunch of fairly complex queries, and work with tables. I've found it useful to reuse the civil.Date type. As part of this, I've written some "helper" utilities, like a Range type and a Min/Max function. Would this be welcomed upstream into the civil package? If so, I'm happy to post my code as a Gerrit CL. If not, feel free to close this: I can also see the argument that this isn't directly used by google-cloud-go, so it shouldn't be supported by this team. I won't be offended, I just thought it could be useful to others.

This is similar to feature requests like #1609 and #1145, which are requesting adding "new" functionality to this package.

@evanj evanj added the triage me I really want to be triaged. label Jan 28, 2020
@tbpg tbpg added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Jan 28, 2020
@tbpg
Copy link
Contributor

tbpg commented Jan 28, 2020

I'm inclined to not add this directly to the civil package. I'm not entirely opposed, but I'm also hesitant to extend the API if there isn't much demand. Of course, helpers might be good in a separate package.

Thank you for filing this issue and not just sending the CL. We really do appreciate it.

@evanj
Copy link
Author

evanj commented Jan 29, 2020

Makes sense to me! I just thought I would offer in case there was interest. civil is pretty useful, it feels like a package that belongs in a golang/x repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants