Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute/metadata: make its own module #6311

Closed
codyoss opened this issue Jul 7, 2022 · 1 comment · Fixed by #6944
Closed

compute/metadata: make its own module #6311

codyoss opened this issue Jul 7, 2022 · 1 comment · Fixed by #6944
Assignees
@codyoss
Labels
api: compute Issues related to the Compute Engine API. type: process A process-related concern. May include testing, release, or the like.

Comments

@codyoss
Copy link
Member

codyoss commented Jul 7, 2022

Now that we generate a compute library we should separate out the metadata package into its own module. This will potentially have a nice benefit of lightening our dependency graph once things rely on it.

Also in the future it would be nice to have a new version of this package/module that is context aware, see #4483. In order to do that though I think we first need to have a stable module to give people time to update should they choose to do so.
@codyoss codyoss added the type: process A process-related concern. May include testing, release, or the like. label Jul 7, 2022
@product-auto-label product-auto-label bot added the api: compute Issues related to the Compute Engine API. label Jul 7, 2022
@codyoss codyoss self-assigned this Oct 26, 2022
This was referenced Oct 26, 2022
Open
Merged
codyoss added a commit that referenced this issue Oct 26, 2022
@codyoss
chore: carve out compute/metadata module (#6940)
478962e 
This commit will be manually tagged
- compute/v1.12.0
- compute/metadata/v0.1.0

Updates: #6311
@codyoss codyoss mentioned this issue Oct 26, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 26, 2022
@codyoss
feat(compute/metadata): drop weak dep on parent module (#6944)
c86c87e 
Fixes: #6311
@liggitt
Copy link
Contributor

liggitt commented Oct 27, 2022

excited to get a tagged version of the dependency-free compute/metadata module so we can help consumers thin out their dependency graphs

@nikhita nikhita mentioned this issue Jan 5, 2023
Closed
@liggitt liggitt mentioned this issue Mar 11, 2024
Merged
@liggitt liggitt mentioned this issue Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyoss codyoss

Labels
api: compute Issues related to the Compute Engine API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(compute/metadata): drop weak dep on parent module codyoss/google-cloud-go
2 participants
@liggitt @codyoss