Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

figure out what to do with godocfx test #8130

Closed
codyoss opened this issue Jun 16, 2023 · 0 comments · Fixed by #8759
Closed

figure out what to do with godocfx test #8130

codyoss opened this issue Jun 16, 2023 · 0 comments · Fixed by #8759
Assignees
@tbpg
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@codyoss
Copy link
Member

codyoss commented Jun 16, 2023

This test fails every time there is a dep bump because it generates off live docs of a client. We should rework the test to be stable or remove it.

Updates: #8129
@codyoss codyoss added the type: cleanup An internal cleanup or hygiene concern. label Jun 16, 2023
@tbpg tbpg mentioned this issue Oct 23, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 23, 2023
@tbpg
chore(internal/godocfx): update godocfx golden (#8757)
0c57c2c 
Updates #8130.
@tbpg tbpg mentioned this issue Oct 23, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 24, 2023
@tbpg
chore(internal/godocfx): test a specific golden package version (#8759)
3e5ba24 
I also updated another test to be less restrictive with the number of files that get generated.

Fixes #8130.
@tbpg tbpg self-assigned this Oct 24, 2023
bhshkh pushed a commit that referenced this issue Nov 3, 2023
@tbpg @bhshkh
chore(internal/godocfx): update godocfx golden (#8757)
245edd9 
Updates #8130.
bhshkh pushed a commit that referenced this issue Nov 3, 2023
@tbpg @bhshkh
chore(internal/godocfx): test a specific golden package version (#8759)
a884ed1 
I also updated another test to be less restrictive with the number of files that get generated.

Fixes #8130.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbpg tbpg

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(internal/godocfx): test a specific golden package version googleapis/google-cloud-go
2 participants
@codyoss @tbpg