Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal/postprocessor): add scopes to all appropriate commit lines #10192

Merged
merged 2 commits into from
May 16, 2024

Conversation

noahdietz
Copy link
Contributor

Adds the scope, if the API directory changed is one configured for gapic generation, to all commit lines inside of a nested commit.

The go-yoshi release-please strategy will only include a commit line from a nested commit if it has a scope and one that matches the module up for release.

Note: not all commit lines in the test data get scopes now - some have nested commits for modules that aren't actually configured for gapic generation anymore i.e. batch/v1alpha1.

Also fixes an issue where we'd get a double bang (internal link) for breaking change commit lines that received scopes (which is now going to be all of them instead of just the first).

@noahdietz noahdietz requested a review from a team as a code owner May 16, 2024 01:11
@quartzmo
Copy link
Member

Note: not all commit lines in the test data get scopes now - some have nested commits for modules that aren't actually configured for gapic generation anymore i.e. batch/v1alpha1.

How hard would it be to update the tests to process only modules that are currently configured? The un-scoped commits seem like a potential source of confusion for future maintainers.

@noahdietz
Copy link
Contributor Author

How hard would it be to update the tests to process only modules that are currently configured? The un-scoped commits seem like a potential source of confusion for future maintainers.

Yeah, I hear you, took me a bit of digging...I think we want to keep them though, they do exercise a condition in the code.

@noahdietz noahdietz merged commit c21399b into googleapis:main May 16, 2024
8 checks passed
@noahdietz noahdietz deleted the postprocessor-add-scopes branch May 16, 2024 16:28
gcf-merge-on-green bot pushed a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants