Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage/transfermanager): add DownloadDirectory #10430

Merged
merged 9 commits into from
Jul 3, 2024
Merged

feat(storage/transfermanager): add DownloadDirectory #10430

merged 9 commits into from
Jul 3, 2024

Commits on Jun 25, 2024

  1. feat(storage/transfermanager): add DownloadDirectory 

    Prototype.

Follow-up PRs:
- Cleanup on failure
- Skipifexists + option to fail if exists?
- strip prefix ? (strip prefix on local files)
- if empty object, create a directory instead ?
- possibly more integration tests
    @BrennaEpp
    BrennaEpp committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    5ecd24b View commit details
    Browse the repository at this point in the history

  2. fix vet

    @BrennaEpp
    BrennaEpp committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    468cb20 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. suggestions (refactor validation, add docs)

    @BrennaEpp
    BrennaEpp committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    a6b5a27 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. suggestions

    @BrennaEpp
    BrennaEpp committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    9d509ad View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. callback is called after all downloads

    @BrennaEpp
    BrennaEpp committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    b63e0da View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into tm-directory

    @BrennaEpp
    BrennaEpp authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    1cb06cb View commit details
    Browse the repository at this point in the history

  3. onobjectdownload is always called

    @BrennaEpp
    BrennaEpp committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    c2d6df1 View commit details
    Browse the repository at this point in the history

  4. add optional to comment

    @BrennaEpp
    BrennaEpp committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    c98f47b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into tm-directory

    @BrennaEpp
    BrennaEpp authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    b550d35 View commit details
    Browse the repository at this point in the history