feat(bigtable): first_response_latencies and connectivity_error_count metrics #10616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
gkevinzheng
approved these changes
Aug 7, 2024
igorbernstein2
requested changes
Aug 27, 2024
| @@ -397,6 +400,7 @@ func (t *Table) readRows(ctx context.Context, arg RowSet, f func(Row) bool, mt * | |||
| *headerMD, _ = stream.Header() | |||
| for { | |||
| res, err := stream.Recv() | |||
| mt.currOp.setFirstRespTime(time.Now()) | |||
There was a problem hiding this comment.
What happens when multiple responses are received?
what happens when there are no rows returned?
is the behavior consistent with java?
Does this work across retries?
There was a problem hiding this comment.
What happens when multiple responses are received?
Updated the code to set only on the first response.
| serverLatAttrs, _ := mt.toOtelMetricAttrs(metricNameServerLatencies) | ||
| if mt.currOp.currAttempt.serverLatencyErr == nil { | ||
| mt.instrumentServerLatencies.Record(mt.ctx, mt.currOp.currAttempt.serverLatency, metric.WithAttributes(serverLatAttrs...)) | ||
| } | ||
| if mt.currOp.currAttempt.serverLatencyErr == nil && mt.currOp.currAttempt.locationErr == nil { | ||
| mt.instrumentConnErrCount.Add(mt.ctx, 0, metric.WithAttributes(connErrCountAttrs...)) |
There was a problem hiding this comment.
do you need to add a zero?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds below metrics: