Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(auth): fix staticcheck errors #10780

Merged
merged 2 commits into from
Aug 29, 2024
Merged

chore(auth): fix staticcheck errors #10780

merged 2 commits into from
Aug 29, 2024

Conversation

julieqiu
Copy link
Member

@julieqiu julieqiu commented Aug 28, 2024 •
edited
Loading

Fix these issues:

credentials/detect.go:102:12: metadata.ProjectID is deprecated: Please use the context aware variant [ProjectIDWithContext].  (SA1019)
credentials/idtoken/compute.go:47:11: metadata.ProjectID is deprecated: Please use the context aware variant [ProjectIDWithContext].  (SA1019)
grpctransport/grpctransport.go:294:9: grpc.DialContext is deprecated: use NewClient instead.  Will be supported throughout 1.x.  (SA1019)
grpctransport/pool_test.go:71:16: grpc.Dial is deprecated: use NewClient instead.  Will be supported throughout 1.x.  (SA1019)
internal/transport/s2a.go:87:9: metadata.Get is deprecated: Please use the context aware variant [GetWithContext].  (SA1019)

For #10779

@julieqiu julieqiu requested a review from a team as a code owner August 28, 2024 01:50
@quartzmo quartzmo mentioned this pull request Aug 28, 2024
Open
@julieqiu julieqiu enabled auto-merge (squash) August 29, 2024 14:11
@julieqiu julieqiu merged commit be2d56d into googleapis:main Aug 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quartzmo quartzmo quartzmo approved these changes

Assignees

@quartzmo quartzmo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julieqiu @quartzmo