Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(auth): use the same now when checking tokenstate #10952

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Oct 4, 2024

I am not sure if this will fix the test, but it is a better behaviour either way I think. If this happens again my only guess is it has to do with rounding depending on the initial time captured. If this test fails again we should use a reletive offset time instead of a fully random time.

Releated: #10950

I am not sure if this will fix the test, but it is a better
behaviour either way I think. If this happens again my only guess
is it has to do with rounding depending on the initial time
captured. If this test fails again we should use a reletive offset
time instead of a fully random time.

Releated: googleapis#10950
@codyoss codyoss requested a review from a team as a code owner October 4, 2024 20:32
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Oct 4, 2024
@codyoss codyoss merged commit 3377a3c into googleapis:main Oct 4, 2024
8 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 4, 2024
@codyoss codyoss deleted the auth-fix branch October 4, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants