feat(storage/dataflux): run worksteal listing parallel to sequential listing #10966
+505
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
BrennaEpp
reviewed
Oct 18, 2024
| } | ||
|
|
||
| // nextPage lists objects using the given lister options. | ||
| func nextPage(ctx context.Context, opts nextPageOpts) (*nextPageResult, error) { |
There was a problem hiding this comment.
This method seems a little convoluted; do you think there is a way to simplify it or make it a little easier to read?
There was a problem hiding this comment.
Update nextPage. Let me know if its more readable now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: run worksteal listing parallel to sequential listing
Dataflux fast-listing leverages worksteal algorithm to quickly list objects in a bucket by running several parallel processes. Worksteal algorithm splits a given namespace into multiple ranges for multiple workers(goroutines) to list objects in gcs bucket in parallel.
Adding logic to list next page in worksteal listing and basic unit tests that uses storage/emulator.
Fixes #10731