feat(pubsub): add support for ingestion platform logging settings #10969
+45
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpri10
reviewed
Oct 9, 2024
pubsub/topic_test.go
Outdated
| @@ -122,6 +122,9 @@ func TestTopic_IngestionKinesis(t *testing.T) { | |||
| AWSRoleARN: "fake-aws-role-arn", | |||
| GCPServiceAccount: "fake-gcp-sa", | |||
| }, | |||
| PlatformLogsSettings: &PlatformLogsSettings{ | |||
There was a problem hiding this comment.
nit: Users are allowed to set Platform Logs settings on Kinesis ingestion topics but we don't actually do any platform logging for Kinesis ingestion. Fine with keeping it or removing it.
michaelpri10
approved these changes
Oct 9, 2024
|
LGTM, thanks for quick turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for platform logging and clarifies that updating a topic to use ingestion requires setting this and source settings in its entirety each time.