Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(pubsub): add doc links to top level package doc #11029

Merged
merged 5 commits into from
Oct 24, 2024
Merged

docs(pubsub): add doc links to top level package doc #11029

merged 5 commits into from
Oct 24, 2024

Conversation

hongalex
Copy link
Member

@hongalex hongalex commented Oct 24, 2024 •
edited
Loading

Things we can't link

  • ReceiveSettings.MaxOutstandingMessages (subfields of structs don't have link)
  • Anything in cloud.google.com/go/internal/pubsub
    • Rendering for this looks like [pkg/cloud.google.com/go/internal/pubsub.Message.Ack]
  • No support for Heading linking (e.g. #Ack Deadlines)

Fixes internal b/360155816

@hongalex hongalex requested review from shollyman and a team as code owners October 24, 2024 01:22
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Oct 24, 2024
@hongalex hongalex enabled auto-merge (squash) October 24, 2024 21:33
@hongalex hongalex merged commit fe2ec56 into googleapis:main Oct 24, 2024
8 checks passed
@hongalex hongalex deleted the docs-pubsub-type-link branch October 24, 2024 21:50
@release-please release-please bot mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quartzmo quartzmo quartzmo approved these changes

@shollyman shollyman Awaiting requested review from shollyman shollyman is a code owner

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hongalex @quartzmo