Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spanner): use spanner options when initializing monitoring exporter #11109

Merged
merged 6 commits into from
Nov 12, 2024
Merged

fix(spanner): use spanner options when initializing monitoring exporter #11109

merged 6 commits into from
Nov 12, 2024

Conversation

rahul2393
Copy link
Contributor

@rahul2393 rahul2393 requested review from a team as code owners November 9, 2024 05:42
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Nov 9, 2024
olavloite
olavloite reviewed Nov 10, 2024
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM, but can we add a test that fails without this change, and succeeds with it? Or is that for some reason not possible?

spanner/metrics.go Outdated Show resolved Hide resolved
@rahul2393 rahul2393 requested a review from olavloite November 12, 2024 06:51
@rahul2393 rahul2393 force-pushed the use-spanner-opts-in-monitoring branch from 02f989c to 0903a4a Compare November 12, 2024 07:27
olavloite
olavloite approved these changes Nov 12, 2024
View reviewed changes
spanner/metrics_monitoring_exporter.go Outdated Show resolved Hide resolved
@rahul2393 rahul2393 force-pushed the use-spanner-opts-in-monitoring branch from c13b30f to 3b31f22 Compare November 12, 2024 16:44
@rahul2393 rahul2393 merged commit 81413f3 into main Nov 12, 2024
9 checks passed
@rahul2393 rahul2393 deleted the use-spanner-opts-in-monitoring branch November 12, 2024 17:04
@release-please release-please bot mentioned this pull request Nov 12, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 14, 2024
@release-please
chore(main): release spanner 1.73.0 (#11116)
f06a55a 
🤖 I have created a release *beep* *boop*
---


## [1.73.0](https://togithub.com/googleapis/google-cloud-go/compare/spanner/v1.72.0...spanner/v1.73.0) (2024-11-14)


### Features

* **spanner:** Add ResetForRetry method for stmt-based transactions ([#10956](https://togithub.com/googleapis/google-cloud-go/issues/10956)) ([02c191c](https://togithub.com/googleapis/google-cloud-go/commit/02c191c5dc13023857812217f63be2395bfcb382))


### Bug Fixes

* **spanner:** Add safecheck to avoid deadlock when creating multiplex session ([#11131](https://togithub.com/googleapis/google-cloud-go/issues/11131)) ([8ee5d05](https://togithub.com/googleapis/google-cloud-go/commit/8ee5d05e288c7105ddb1722071d6719933effea4))
* **spanner:** Allow non default service account only when direct path is enabled ([#11046](https://togithub.com/googleapis/google-cloud-go/issues/11046)) ([4250788](https://togithub.com/googleapis/google-cloud-go/commit/42507887523f41d0507ca8b1772235846947c3e0))
* **spanner:** Use spanner options when initializing monitoring exporter ([#11109](https://togithub.com/googleapis/google-cloud-go/issues/11109)) ([81413f3](https://togithub.com/googleapis/google-cloud-go/commit/81413f3647a0ea406f25d4159db19b7ad9f0682b))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@rahul2393 rahul2393 mentioned this pull request Dec 5, 2024
Closed
@manu2 manu2 mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@harshachinta harshachinta Awaiting requested review from harshachinta

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahul2393 @olavloite