Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): Support a cookie header in calls. #11614

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cjc25
Copy link
Contributor

@cjc25 cjc25 commented Feb 20, 2025

This allows callers to run storage clients with an environment variable that propagates tracing cookies.

This allows callers to run storage clients with an environment variable
that propagates tracing cookies.
@cjc25 cjc25 requested review from a team as code owners February 20, 2025 03:58
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Feb 20, 2025
@tritone tritone changed the title feat(storage): Support a cookie header in calls. chore(storage): Support a cookie header in calls. Feb 20, 2025
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Also, changed PR type to "chore" since it's not an officially documented API so we don't want this in release notes.


var (
cookieHeader = sync.OnceValue(func() string {
return os.Getenv("STORAGE_TRACING_COOKIE")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do GOOGLE_SDK_GO_TRACING_COOKIE (matches prefix of some other env vars in the library).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants