Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: fix scheme lost when use endpoint #3509

Closed
wants to merge 6 commits into from

Conversation

3pointer
Copy link

@3pointer 3pointer commented Jan 7, 2021

Client should choose the correct scheme when using the endpoint with scheme (http://localhost:8080). or it will return
Get https://localhost:8080/xxx: http: server gave HTTP response to HTTPS client" when client try to use NewRangeReader to read objects.

@3pointer 3pointer requested review from tritone and a team as code owners January 7, 2021 11:56
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jan 7, 2021
@google-cla
Copy link

google-cla bot commented Jan 7, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Jan 7, 2021
@3pointer
Copy link
Author

3pointer commented Jan 7, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 7, 2021
@3pointer 3pointer requested a review from a team June 21, 2021 06:26
@3pointer
Copy link
Author

Hi, Is there any chance for this PR merged?

@ddelgrosso1 ddelgrosso1 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 28, 2021
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 28, 2021
@ddelgrosso1 ddelgrosso1 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 29, 2021
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 29, 2021
@3pointer
Copy link
Author

3pointer commented Aug 4, 2021

Test Case Failed in

WantRawBasePath: "https://fake.gcs.com:8080/storage/v1",
WantReadHost: "fake.gcs.com:8080",
WantScheme: "http",

WantRawBasePath is https://xxx but WantScheme is http, is this test case wrong? or did I miss something?

@3pointer
Copy link
Author

3pointer commented Aug 5, 2021

Test Case Failed in https://github.com/googleapis/google-cloud-go/blob/master/storage/storage_test.go#L1285-L1287.

WantRawBasePath is https://xxx but WantScheme is http, is this test case wrong? or did I miss something?

@ddelgrosso1 could you help me with this?

@BrennaEpp
Copy link
Contributor

Hi @3pointer, thank you for filing this PR and raising this issue. We are currently looking at related issues and investigating why this is failing. I will update once we know more.

@BrennaEpp
Copy link
Contributor

Hi @3pointer, I created a PR against your branch to fix the failing test. If you agree with those changes, please merge and then we can merge this in.

@BrennaEpp
Copy link
Contributor

Similar changes were merged in. Thanks for your contribution! Please open an issue or reopen this request if you are still having issues.

@3pointer
Copy link
Author

Similar changes were merged in. Thanks for your contribution! Please open an issue or reopen this request if you are still having issues.

OK, let me try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants