-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: fix scheme lost when use endpoint #3509
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Hi, Is there any chance for this PR merged? |
Test Case Failed in google-cloud-go/storage/storage_test.go Lines 1285 to 1287 in e36b29a
|
@ddelgrosso1 could you help me with this? |
Hi @3pointer, thank you for filing this PR and raising this issue. We are currently looking at related issues and investigating why this is failing. I will update once we know more. |
Hi @3pointer, I created a PR against your branch to fix the failing test. If you agree with those changes, please merge and then we can merge this in. |
Similar changes were merged in. Thanks for your contribution! Please open an issue or reopen this request if you are still having issues. |
OK, let me try. |
Client should choose the correct scheme when using the endpoint with scheme (http://localhost:8080). or it will return
Get https://localhost:8080/xxx: http: server gave HTTP response to HTTPS client"
when client try to use NewRangeReader to read objects.