Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logging): cloud run and functions resource autodetection #3909

Merged
merged 10 commits into from
Apr 14, 2021
Merged

feat(logging): cloud run and functions resource autodetection #3909

merged 10 commits into from
Apr 14, 2021

Conversation

freelerobot
Copy link
Contributor

@freelerobot freelerobot commented Apr 9, 2021 •
edited
Loading

Fixes: #3486

Changes:

  • cloud run has correct resource labels and type
  • functions has correct resource labels and type
  • e2e environment tests covered here

@freelerobot freelerobot self-assigned this Apr 9, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 9, 2021
@product-auto-label product-auto-label bot added the api: logging Issues related to the Cloud Logging API. label Apr 9, 2021
@freelerobot freelerobot changed the title feat(logging): cloud run resource autodetection feat(logging): cloud run and functions resource autodetection Apr 9, 2021
@freelerobot freelerobot marked this pull request as ready for review April 9, 2021 21:56
@freelerobot freelerobot requested review from a team as code owners April 9, 2021 21:56
simonz130
simonz130 reviewed Apr 12, 2021
View reviewed changes
Copy link

@simonz130 simonz130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thank you!

logging/logging.go Show resolved Hide resolved
logging/logging.go Show resolved Hide resolved
daniel-sanche
daniel-sanche reviewed Apr 12, 2021
View reviewed changes
logging/logging.go Show resolved Hide resolved
logging/logging.go Show resolved Hide resolved
logging/logging.go Show resolved Hide resolved
logging/logging.go Outdated Show resolved Hide resolved
logging/logging.go Show resolved Hide resolved
@freelerobot
Copy link
Contributor Author

Ready for another look @simonz130 or @daniel-sanche when you have time
@daniel-sanche I realize the library memoizes already. detectResource is run once upon logger initialization

codyoss
codyoss approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@freelerobot freelerobot added priority: p2 Moderately-important priority. Fix may not be included in next release. automerge Merge the pull request once unit tests and other checks pass. labels Apr 13, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1204de8 into master Apr 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the envCloudRun branch April 14, 2021 00:10
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 14, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 15, 2021
@yoshi-code-bot
chore: release logging 1.4.0 (#3940)
b52cc49 
🤖 I have created a release \*beep\* \*boop\*
---
## [1.4.0](https://www.github.com/googleapis/google-cloud-go/compare/logging/v1.2.0...logging/v1.4.0) (2021-04-15)


### Features

* **logging:** cloud run and functions resource autodetection ([#3909](https://www.github.com/googleapis/google-cloud-go/issues/3909)) ([1204de8](https://www.github.com/googleapis/google-cloud-go/commit/1204de85e58334bf93fecdcb0ab8b581449c2745))
* **logging:** make toLogEntry function public ([#3863](https://www.github.com/googleapis/google-cloud-go/issues/3863)) ([71828c2](https://www.github.com/googleapis/google-cloud-go/commit/71828c28d424c34da6d0392651739a364cd57e79))


### Bug Fixes

* **logging:** Entries has a 24H default filter ([#3120](https://www.github.com/googleapis/google-cloud-go/issues/3120)) ([b32eb82](https://www.github.com/googleapis/google-cloud-go/commit/b32eb822d17838bde91c610a5a9d392d325a592d))

This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@someone1 someone1 mentioned this pull request Apr 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonz130 simonz130 simonz130 approved these changes

@codyoss codyoss codyoss approved these changes

@daniel-sanche daniel-sanche daniel-sanche approved these changes

Assignees

@freelerobot freelerobot

Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logging: resource autodetection for CloudRun
4 participants
@freelerobot @daniel-sanche @codyoss @simonz130