Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage): internal client interface design #5426

Merged
merged 11 commits into from
Feb 22, 2022
Merged

chore(storage): internal client interface design #5426

merged 11 commits into from
Feb 22, 2022

Conversation

noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Feb 2, 2022 •
edited
Loading

Introduces an internal interface for the Storage client implementation. This is a transport-agnostic client surface. Additionally, internal, supporting types like settings and storageOption are added to help the client layer convey API call-related configuration (e.g. retry config).

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the Cloud Storage API. labels Feb 2, 2022
@noahdietz noahdietz marked this pull request as ready for review February 14, 2022 23:19
@noahdietz noahdietz requested review from a team as code owners February 14, 2022 23:19
tritone
tritone reviewed Feb 15, 2022
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good with a few comments. I assume we'll have to make further revisions once we try implementing some methods, but since this is unexported I guess we're not married to this surface.

storage/client.go Show resolved Hide resolved
storage/client.go Outdated Show resolved Hide resolved
storage/client.go Show resolved Hide resolved
@noahdietz noahdietz requested a review from tritone February 17, 2022 02:27
tritone
tritone approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion on HMAC, otherwise LGTM

storage/client.go Show resolved Hide resolved
tritone
tritone reviewed Feb 22, 2022
View reviewed changes
storage/client.go Outdated Show resolved Hide resolved
@noahdietz noahdietz merged commit 9775203 into googleapis:main Feb 22, 2022
@noahdietz noahdietz deleted the storage-interface branch February 22, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noahdietz @tritone