test(spanner): enable more tests on emulator #5442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The emulator now supports all data types that are also supported by Cloud Spanner. The integration tests also unnecessarily skipped a large number of tests that tried to insert untyped null values as it was assumed that this was not supported. That is however supported for most data types, and only DATE and TIMESTAMP need to be skipped. Updates #GoogleCloudPlatform/cloud-spanner-emulator#31
product-auto-label
bot
added
size: s
olavloite
commented
Feb 3, 2022
| @@ -1647,7 +1644,6 @@ func TestIntegration_BasicTypes(t *testing.T) { | |||
| {col: "String", val: "foo", want: NullString{"foo", true}}, | |||
| {col: "String", val: NullString{"bar", true}, want: "bar"}, | |||
| {col: "String", val: NullString{"bar", false}, want: NullString{"", false}}, | |||
| {col: "String", val: nil, want: NullString{}}, | |||
There was a problem hiding this comment.
Removed as it was a duplicate (the same test is on line 1737). This also applies to a couple of other tests below.
snehashah16
approved these changes
Feb 3, 2022
rahul2393
approved these changes
Feb 4, 2022
|
Build error is caused by a missing library on the test server that seems to be required by the latest version of the emulator:
|
This reverts commit 6d8e61e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The emulator now supports all data types that are also supported by
Cloud Spanner. The integration tests also unnecessarily skipped a large
number of tests that tried to insert untyped null values as it was
assumed that this was not supported. That is however supported for most
data types, and only DATE and TIMESTAMP need to be skipped.
Updates #GoogleCloudPlatform/cloud-spanner-emulator#31