-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(spanner): enable more tests on emulator #5442
Conversation
The emulator now supports all data types that are also supported by Cloud Spanner. The integration tests also unnecessarily skipped a large number of tests that tried to insert untyped null values as it was assumed that this was not supported. That is however supported for most data types, and only DATE and TIMESTAMP need to be skipped. Updates #GoogleCloudPlatform/cloud-spanner-emulator#31
@@ -1647,7 +1644,6 @@ func TestIntegration_BasicTypes(t *testing.T) { | |||
{col: "String", val: "foo", want: NullString{"foo", true}}, | |||
{col: "String", val: NullString{"bar", true}, want: "bar"}, | |||
{col: "String", val: NullString{"bar", false}, want: NullString{"", false}}, | |||
{col: "String", val: nil, want: NullString{}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed as it was a duplicate (the same test is on line 1737). This also applies to a couple of other tests below.
Build error is caused by a missing library on the test server that seems to be required by the latest version of the emulator:
|
This reverts commit 6d8e61e.
The emulator now supports all data types that are also supported by
Cloud Spanner. The integration tests also unnecessarily skipped a large
number of tests that tried to insert untyped null values as it was
assumed that this was not supported. That is however supported for most
data types, and only DATE and TIMESTAMP need to be skipped.
Updates #GoogleCloudPlatform/cloud-spanner-emulator#31