feat(pubsublite): create/update export subscriptions #6885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tmdiep
commented
Oct 18, 2022
•
tmdiep
commented
- Added support for creating and updating export subscriptions, which write messages to a configured destination, for example a Pub/Sub topic. More destination types may be supported in the future.
- Added support for creating subscriptions initialized to a target location within the message backlog. A seek is performed for publish and event timestamps.
product-auto-label
bot
added
size: l
|
@codyoss Can you please review the API surface changes in pubsublite/config.go and pubsublite/admin.go. Thanks! |
tmdiep
added
the
do not merge
codyoss
reviewed
Oct 21, 2022
| @@ -211,6 +212,121 @@ func (tc *TopicConfigToUpdate) toUpdateRequest() *pb.UpdateTopicRequest { | |||
| } | |||
| } | |||
|
|
|||
| // ExportDestinationConfig is the configuration for exporting to a destination. | |||
| // Implemented by *PubSubConfig. | |||
| type ExportDestinationConfig interface { | |||
There was a problem hiding this comment.
How many of these do you anticipate? Could this just be a config struct instead of having the extra indirection?
There was a problem hiding this comment.
We can't predict how many, but there may be several in the future, hence the oneof-like representation.
hongalex
approved these changes
Nov 17, 2022
product-auto-label
bot
added
the
stale: old
tmdiep
removed
the
do not merge
tmdiep
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 12, 2022
🤖 I have created a release *beep* *boop* --- ## [1.6.0](https://togithub.com/googleapis/google-cloud-go/compare/pubsublite/v1.5.0...pubsublite/v1.6.0) (2022-12-10) ### Features * **pubsublite:** Create/update export subscriptions ([#6885](https://togithub.com/googleapis/google-cloud-go/issues/6885)) ([5fa8555](https://togithub.com/googleapis/google-cloud-go/commit/5fa855545502ab01775d19cc7b42810beefd1d5f)) * **pubsublite:** rewrite signatures and type in terms of new location ([620e6d8](https://togithub.com/googleapis/google-cloud-go/commit/620e6d828ad8641663ae351bfccfe46281e817ad)) * **pubsublite:** Unload idle partition publishers ([#7105](https://togithub.com/googleapis/google-cloud-go/issues/7105)) ([176f533](https://togithub.com/googleapis/google-cloud-go/commit/176f5331ff02dd9ae4eb706f299b31c903689298)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.