Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigquery): add dataset/table collation #7235

Merged
merged 5 commits into from
Jan 13, 2023
Merged

feat(bigquery): add dataset/table collation #7235

merged 5 commits into from
Jan 13, 2023

Conversation

alvarowolfx
Copy link
Contributor

No description provided.

@alvarowolfx alvarowolfx requested a review from a team January 10, 2023 21:30
@alvarowolfx alvarowolfx requested a review from a team as a code owner January 10, 2023 21:30
@alvarowolfx alvarowolfx requested a review from tswast January 10, 2023 21:30
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the BigQuery API. labels Jan 10, 2023
@alvarowolfx alvarowolfx requested review from shollyman and removed request for tswast January 10, 2023 22:30
shollyman
shollyman reviewed Jan 11, 2023
View reviewed changes
bigquery/dataset.go Outdated Show resolved Hide resolved
bigquery/dataset.go Outdated Show resolved Hide resolved
bigquery/table_integration_test.go Outdated Show resolved Hide resolved
@alvarowolfx alvarowolfx requested a review from shollyman January 11, 2023 21:10
shollyman
shollyman approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Do we have a link to BQ docs we can add to the new fields to help users understand the behaviors in more detail? If so, let's reference them in the field comments.

bigquery/table_integration_test.go Outdated Show resolved Hide resolved
@alvarowolfx alvarowolfx added the automerge Merge the pull request once unit tests and other checks pass. label Jan 13, 2023
@alvarowolfx alvarowolfx requested a review from shollyman January 13, 2023 18:47
@gcf-merge-on-green gcf-merge-on-green bot merged commit 9f7bbeb into googleapis:main Jan 13, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 13, 2023
@release-please release-please bot mentioned this pull request Jan 13, 2023
Closed
alvarowolfx added a commit that referenced this pull request Jan 13, 2023
@alvarowolfx
Revert "feat(bigquery): add dataset/table collation (#7235)"
39d0604 
This reverts commit 9f7bbeb.
@alvarowolfx alvarowolfx mentioned this pull request Jan 13, 2023
Closed
@release-please release-please bot mentioned this pull request Jan 26, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 7, 2023
@release-please
chore(main): release bigquery 1.46.0 (#7307)
225b525 
🤖 I have created a release *beep* *boop*
---


## [1.46.0](https://togithub.com/googleapis/google-cloud-go/compare/bigquery/v1.45.0...bigquery/v1.46.0) (2023-02-06)


### Features

* **bigquery:** Add dataset/table collation ([#7235](https://togithub.com/googleapis/google-cloud-go/issues/7235)) ([9f7bbeb](https://togithub.com/googleapis/google-cloud-go/commit/9f7bbeb466bd7572544c4178a33370a25b5f1496))
* **bigquery:** Use storage api for query jobs ([#6822](https://togithub.com/googleapis/google-cloud-go/issues/6822)) ([26c04f4](https://togithub.com/googleapis/google-cloud-go/commit/26c04f4cd5083b4aa3c219500572d3af2f291645))


### Bug Fixes

* **bigquery:** Create/update an isolated dataset for collation feature ([#7256](https://togithub.com/googleapis/google-cloud-go/issues/7256)) ([b371558](https://togithub.com/googleapis/google-cloud-go/commit/b3715585aa6892fc41a29027694c72f31390441a))
* **bigquery:** Fetch dst table for jobs when readings with Storage API ([#7325](https://togithub.com/googleapis/google-cloud-go/issues/7325)) ([0bf80d7](https://togithub.com/googleapis/google-cloud-go/commit/0bf80d72a893755adefdead900e8990ed53d9627)), refs [#7322](https://togithub.com/googleapis/google-cloud-go/issues/7322)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This was referenced Feb 14, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvarowolfx @shollyman