chore(internal/postprocessor): add MoveSnippets to main.go #7523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyoss
reviewed
Mar 9, 2023
internal/postprocessor/main.go
Outdated
| dirs := c.getDirs() | ||
| for _, dir := range dirs { | ||
|
|
||
| snpDirs, err := filepath.Glob(filepath.Join(dir, "api*", "internal")) |
There was a problem hiding this comment.
I would use apiv to reduce the chance of false positives. Did you test this locally to see if this would only trigger as expected?
There was a problem hiding this comment.
See Pr desc for local test confirmation.
quartzmo
added
the
do not merge
|
|
quartzmo
removed
the
do not merge
|
Tested updates locally with: Output as expected, no errors. |
quartzmo
force-pushed
the
postprocessor-move-snippets
branch
from
3b27dde
to
42c17aa
Compare
|
@quartzmo can you update the hash for the postprocessor to include these changes |
codyoss
approved these changes
Apr 7, 2023
quartzmo
added a commit
to quartzmo/google-cloud-go
that referenced
this pull request
Apr 11, 2023
…Snippets * delete postprocessor/snippets.go refs: googleapis#7523
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary change to delete generated snippets until we are ready to process them.
Tested locally by adding an
internal/snippetsdirectory to onlykms/apiv1, then running over all modules, to confirm that Glob pattern does not gather unwanted paths.