Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: onboard compute to owlbot #7705

Merged
merged 4 commits into from
Apr 6, 2023

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Apr 6, 2023

No description provided.

@codyoss codyoss requested a review from a team as a code owner April 6, 2023 21:12
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 6, 2023
@noahdietz
Copy link
Contributor

There is a nasty hack to add an extra generator flag specifically for compute:

// This is a bummer way of toggling diregapic generation, but it compute is the only one for the near term.
if conf.Pkg == "compute" {
args = append(args, "--go_gapic_opt", "diregapic")
}

There is a bazel equivalent I believe. I just remembered this, sorry face palm

Copy link
Contributor

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once googleapis/googleapis#793 is in

@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Apr 6, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2a5c165 into googleapis:main Apr 6, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants