Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigquery/storage/managedwriter): context refactoring #8275

Merged
merged 9 commits into from
Jul 21, 2023

Commits on Jul 17, 2023

  1. fix(bigquery/storage/managedwriter): context refactoring

    This PR refactors how contexts are retained in the managedwriter
    package.  Prior to multiplexing, each writer had a dedicated connection,
    and context could be shared between writer and the connection.
    
    Now, the relationship between writers and their backing connections is
    more nuanced.  Now, we use the context provided as part of client
    instantiation (e.g. NewClient) for connection and pool management, and
    context provided in NewManagedWriter is scoped to _just_ that specific
    writer.
    
    This corrects the previous problem where the context for the first
    writer in a connection pool would be used for pool and connection
    management, and thus a cancellation of a single  writer's context
    could trigger writes from other writer instances to fail.
    shollyman committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    b624006 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Configuration menu
    Copy the full SHA
    bc5b274 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0adc78e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0d12cee View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Configuration menu
    Copy the full SHA
    77aba45 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cbb18e9 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Configuration menu
    Copy the full SHA
    969cee0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c6f3e9 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Configuration menu
    Copy the full SHA
    b0e112c View commit details
    Browse the repository at this point in the history