-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bigquery/storage/managedwriter): context refactoring #8275
Merged
Commits on Jul 17, 2023
-
fix(bigquery/storage/managedwriter): context refactoring
This PR refactors how contexts are retained in the managedwriter package. Prior to multiplexing, each writer had a dedicated connection, and context could be shared between writer and the connection. Now, the relationship between writers and their backing connections is more nuanced. Now, we use the context provided as part of client instantiation (e.g. NewClient) for connection and pool management, and context provided in NewManagedWriter is scoped to _just_ that specific writer. This corrects the previous problem where the context for the first writer in a connection pool would be used for pool and connection management, and thus a cancellation of a single writer's context could trigger writes from other writer instances to fail.
Configuration menu - View commit details
-
Copy full SHA for b624006 - Browse repository at this point
Copy the full SHA b624006View commit details
Commits on Jul 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bc5b274 - Browse repository at this point
Copy the full SHA bc5b274View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0adc78e - Browse repository at this point
Copy the full SHA 0adc78eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d12cee - Browse repository at this point
Copy the full SHA 0d12ceeView commit details
Commits on Jul 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 77aba45 - Browse repository at this point
Copy the full SHA 77aba45View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbb18e9 - Browse repository at this point
Copy the full SHA cbb18e9View commit details
Commits on Jul 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 969cee0 - Browse repository at this point
Copy the full SHA 969cee0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c6f3e9 - Browse repository at this point
Copy the full SHA 2c6f3e9View commit details
Commits on Jul 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b0e112c - Browse repository at this point
Copy the full SHA b0e112cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.