Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigquery): update google.golang.org/api version to v0.147.0 #8952

Closed
wants to merge 1 commit into from

Conversation

nktks
Copy link
Contributor

@nktks nktks commented Nov 1, 2023

fix #8946

  • In below code, build was failed.
  • I think it need to update google.golang.org/api version to v0.147.0 if google.golang.org/api v0.147.0 is not required indirectly.

reproduction code

  • main.go
package main

import (
	"context"
	"fmt"
	"log"

	"cloud.google.com/go/bigquery"
)

func main() {
	if err := relaxTableQuery("project", "dataset", "table"); err != nil {
		log.Fatal(err)
	}
}

func relaxTableQuery(projectID, datasetID, tableID string) error {
	ctx := context.Background()
	client, err := bigquery.NewClient(ctx, projectID)
	if err != nil {
		return fmt.Errorf("bigquery.NewClient: %v", err)
	}
	defer client.Close()
}
  • execute go mod init && go mod tidy
  • go.mod
module github.com/nktks/test/bq

go 1.21.3

require cloud.google.com/go/bigquery v1.57.0

require (
	cloud.google.com/go v0.110.7 // indirect
	cloud.google.com/go/compute v1.23.0 // indirect
	cloud.google.com/go/compute/metadata v0.2.3 // indirect
	cloud.google.com/go/iam v1.1.1 // indirect
	github.com/andybalholm/brotli v1.0.4 // indirect
	github.com/apache/arrow/go/v12 v12.0.0 // indirect
	github.com/apache/thrift v0.16.0 // indirect
	github.com/goccy/go-json v0.9.11 // indirect
	github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
	github.com/golang/protobuf v1.5.3 // indirect
	github.com/golang/snappy v0.0.4 // indirect
	github.com/google/flatbuffers v2.0.8+incompatible // indirect
	github.com/google/s2a-go v0.1.5 // indirect
	github.com/google/uuid v1.3.1 // indirect
	github.com/googleapis/enterprise-certificate-proxy v0.3.1 // indirect
	github.com/googleapis/gax-go/v2 v2.12.0 // indirect
	github.com/klauspost/asmfmt v1.3.2 // indirect
	github.com/klauspost/compress v1.15.9 // indirect
	github.com/klauspost/cpuid/v2 v2.0.9 // indirect
	github.com/minio/asm2plan9s v0.0.0-20200509001527-cdd76441f9d8 // indirect
	github.com/minio/c2goasm v0.0.0-20190812172519-36a3d3bbc4f3 // indirect
	github.com/pierrec/lz4/v4 v4.1.15 // indirect
	github.com/zeebo/xxh3 v1.0.2 // indirect
	go.opencensus.io v0.24.0 // indirect
	golang.org/x/crypto v0.14.0 // indirect
	golang.org/x/mod v0.10.0 // indirect
	golang.org/x/net v0.17.0 // indirect
	golang.org/x/oauth2 v0.12.0 // indirect
	golang.org/x/sync v0.3.0 // indirect
	golang.org/x/sys v0.13.0 // indirect
	golang.org/x/text v0.13.0 // indirect
	golang.org/x/tools v0.9.1 // indirect
	golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2 // indirect
	google.golang.org/api v0.134.0 // indirect
	google.golang.org/appengine v1.6.7 // indirect
	google.golang.org/genproto v0.0.0-20230822172742-b8732ec3820d // indirect
	google.golang.org/genproto/googleapis/api v0.0.0-20230822172742-b8732ec3820d // indirect
	google.golang.org/genproto/googleapis/rpc v0.0.0-20230822172742-b8732ec3820d // indirect
	google.golang.org/grpc v1.59.0 // indirect
	google.golang.org/protobuf v1.31.0 // indirect
)
  • build
go build main.go
# cloud.google.com/go/bigquery
../../../../../pkg/mod/cloud.google.com/go/bigquery@v1.57.0/dataset.go:249:6: ds.ExternalDatasetReference undefined (type *"google.golang.org/api/bigquery/v2".Dataset has no field or method ExternalDatasetReference)
../../../../../pkg/mod/cloud.google.com/go/bigquery@v1.57.0/dataset.go:316:62: d.ExternalDatasetReference undefined (type *"google.golang.org/api/bigquery/v2".Dataset has no field or method ExternalDatasetReference)
../../../../../pkg/mod/cloud.google.com/go/bigquery@v1.57.0/dataset.go:409:6: ds.ExternalDatasetReference undefined (type *"google.golang.org/api/bigquery/v2".Dataset has no field or method ExternalDatasetReference)
../../../../../pkg/mod/cloud.google.com/go/bigquery@v1.57.0/dataset.go:964:42: undefined: bq.ExternalDatasetReference
../../../../../pkg/mod/cloud.google.com/go/bigquery@v1.57.0/dataset.go:974:49: undefined: bq.ExternalDatasetReference
../../../../../pkg/mod/cloud.google.com/go/bigquery@v1.57.0/dataset.go:978:13: undefined: bq.ExternalDatasetReference
../../../../../pkg/mod/cloud.google.com/go/bigquery@v1.57.0/query.go:491:12: qRequest.JobCreationMode undefined (type *"google.golang.org/api/bigquery/v2".QueryRequest has no field or method JobCreationMode)

@nktks nktks requested review from a team as code owners November 1, 2023 07:12
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the BigQuery API. labels Nov 1, 2023
@nktks nktks force-pushed the bigquery-bumpup-api-pkg-version branch from 8a82ab3 to c7e43bd Compare November 1, 2023 07:16
@nktks nktks changed the title fix(bigquery):update google.golang.org/api version to v0.147.0 fix(bigquery): update google.golang.org/api version to v0.147.0 Nov 1, 2023
@alvarowolfx
Copy link
Contributor

closing as this was superseded by #8958

@alvarowolfx alvarowolfx closed this Nov 1, 2023
@nktks nktks deleted the bigquery-bumpup-api-pkg-version branch November 2, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bigquery: wrong google.golang.org/api version causes any build to fail since version v1.57.0
2 participants