feat(bigtable): Support copy backup in admin client #9005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
kolea2
suggested changes
Nov 29, 2023
kolea2
approved these changes
Nov 30, 2023
quartzmo
reviewed
Nov 30, 2023
| @@ -132,6 +136,7 @@ project's service account. | |||
| - `GCLOUD_TESTS_GOLANG_FIRESTORE_KEY`: The path to the JSON key file of the | |||
| Firestore project's service account. | |||
| - `GCLOUD_TESTS_API_KEY`: API key for using the Translate API created above. | |||
| - `GCLOUD_TESTS_GOLANG_SECONDARY_BIGTABLE_PROJECT_ID`: Developers Console project's ID (e.g. doorway-cliff-677) for Bigtable optional secondary project. This can be same as Firestore project or any project other than the general project. | |||
There was a problem hiding this comment.
Why isn't an env var needed for a Bigtable API key, similar to the other projects?
There was a problem hiding this comment.
Only Translate API is using API key for running tests.
None of the Bigtable tests use the API key for authentication.
There was a problem hiding this comment.
It looks to me like the Bigtable test might now depend on GCLOUD_TESTS_GOLANG_FIRESTORE_KEY, is that correct?
quartzmo
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CopyBackup method to admin client using which existing backups can be copied to a same or different project.