fix(bigquery): align return time.Time values to UTC #9411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in googleapis#9368 changed the expectation that constructed time.Time objects would use UTC time for location. This PR returns to the old behavior by forcing the values to be returned aligned to UTC time, and avoid using the local timezone for construction. Fixes: googleapis#9407
product-auto-label
bot
added
size: xs
alvarowolfx
approved these changes
Feb 12, 2024
This was referenced Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #9368 changed the expectation that constructed time.Time objects would use UTC time for location. This PR returns to the old behavior by forcing the values to be returned aligned to UTC time, and avoid using the local timezone for construction.
Fixes: #9407