feat(spanner): allow attempt direct path xds via env var #9582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul2393
changed the title
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
rahul2393
approved these changes
Mar 15, 2024
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable Direct Access, both
EnableDirectPathandEnableDirectPathXdsshould be added in the client options for grpctransport to append the correct google-c2p scheme.This PR adds a env var
GOOGLE_SPANNER_ENABLE_DIRECT_ACCESSto control the enable/disable of Direct Access. When it is true, it adds theEnableDirectPathXdsoption which effectively turns on Direct Access (EnableDirectPathhas already been added above).BEGIN_COMMIT_OVERRIDE
feat(spanner): Allow attempt direct path xds via env var
END_COMMIT_OVERRIDE