Make sure getters start with the get prefix

googleapis · Nov 8, 2016 · 1038a52 · 1038a52
1 parent bfb875e
commit 1038a52
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/google-cloud-core/src/main/java/com/google/cloud/testing/BaseEmulatorHelper.java b/google-cloud-core/src/main/java/com/google/cloud/testing/BaseEmulatorHelper.java
@@ -73,7 +73,7 @@ protected BaseEmulatorHelper(String emulator, int port, String projectId) {
    * Returns the emulator runners supported by this emulator. Runners are evaluated in order, the
    * first available runner is selected and executed
    */
-  protected abstract List<EmulatorRunner> emulatorRunners();
+  protected abstract List<EmulatorRunner> getEmulatorRunners();
 
   /**
    * Returns a logger.
@@ -86,7 +86,7 @@ protected BaseEmulatorHelper(String emulator, int port, String projectId) {
    */
   protected final void startProcess(String blockUntilOutput)
       throws IOException, InterruptedException {
-    for (EmulatorRunner runner : emulatorRunners()) {
+    for (EmulatorRunner runner : getEmulatorRunners()) {
       // Iterate through all emulator runners until find first available runner.
       if (runner.isAvailable()) {
         activeRunner = runner;
@@ -262,11 +262,11 @@ private boolean isGcloudInstalled() {
     }
 
     private boolean isEmulatorUpToDate() throws IOException, InterruptedException {
-      Version currentVersion = installedEmulatorVersion(versionPrefix);
+      Version currentVersion = getInstalledEmulatorVersion(versionPrefix);
       return currentVersion != null && currentVersion.compareTo(minVersion) >= 0;
     }
 
-    private Version installedEmulatorVersion(String versionPrefix)
+    private Version getInstalledEmulatorVersion(String versionPrefix)
         throws IOException, InterruptedException {
       Process process =
           CommandWrapper.create()

diff --git a/google-cloud-core/src/test/java/com/google/cloud/testing/BaseEmulatorHelperTest.java b/google-cloud-core/src/test/java/com/google/cloud/testing/BaseEmulatorHelperTest.java
@@ -46,7 +46,7 @@ private TestEmulatorHelper(List<EmulatorRunner> runners, String blockUntil) {
     }
 
     @Override
-    protected List<EmulatorRunner> emulatorRunners() {
+    protected List<EmulatorRunner> getEmulatorRunners() {
       return runners;
     }
 

diff --git a/...loud-datastore/src/main/java/com/google/cloud/datastore/testing/LocalDatastoreHelper.java b/...loud-datastore/src/main/java/com/google/cloud/datastore/testing/LocalDatastoreHelper.java
@@ -107,7 +107,7 @@ private LocalDatastoreHelper(double consistency) {
   }
 
   @Override
-  protected List<EmulatorRunner> emulatorRunners() {
+  protected List<EmulatorRunner> getEmulatorRunners() {
     return emulatorRunners;
   }
 

diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/testing/LocalPubSubHelper.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/testing/LocalPubSubHelper.java
@@ -83,7 +83,7 @@ private LocalPubSubHelper() {
   }
 
   @Override
-  protected List<EmulatorRunner> emulatorRunners() {
+  protected List<EmulatorRunner> getEmulatorRunners() {
     return emulatorRunners;
   }