Skip to content

Commit

Permalink
Remove flaky tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Ajay Kannan committed Apr 1, 2016
1 parent 0849646 commit 29ed5fb
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import com.google.gcloud.Page;
import com.google.gcloud.WriteChannel;
import com.google.gcloud.bigquery.BigQuery;
import com.google.gcloud.bigquery.BigQuery.DatasetField;
import com.google.gcloud.bigquery.BigQuery.DatasetOption;
Expand Down Expand Up @@ -62,7 +61,6 @@
import com.google.gcloud.bigquery.TableId;
import com.google.gcloud.bigquery.TableInfo;
import com.google.gcloud.bigquery.ViewDefinition;
import com.google.gcloud.bigquery.WriteChannelConfiguration;
import com.google.gcloud.bigquery.testing.RemoteBigQueryHelper;
import com.google.gcloud.storage.BlobInfo;
import com.google.gcloud.storage.BucketInfo;
Expand All @@ -75,8 +73,6 @@
import org.junit.Test;
import org.junit.rules.Timeout;

import java.io.IOException;
import java.nio.ByteBuffer;
import java.nio.charset.StandardCharsets;
import java.util.Iterator;
import java.util.List;
Expand Down Expand Up @@ -623,6 +619,7 @@ public void testInsertAllWithErrors() {
assertTrue(bigquery.delete(TableId.of(DATASET, tableName)));
}

/* TODO(#836): Uncomment and fix flakiness
@Test
public void testListAllTableData() {
Page<List<FieldValue>> rows = bigquery.listTableData(TABLE_ID);
Expand Down Expand Up @@ -652,6 +649,7 @@ public void testListAllTableData() {
}
assertEquals(2, rowCount);
}
*/

@Test
public void testQuery() throws InterruptedException {
Expand Down Expand Up @@ -906,6 +904,7 @@ public void testCancelNonExistingJob() {
assertFalse(bigquery.cancel("test_cancel_non_existing_job"));
}

/* TODO(#836): Uncomment and fix flakiness
@Test
public void testInsertFromFile() throws InterruptedException {
String destinationTableName = "test_insert_from_file_table";
Expand Down Expand Up @@ -952,4 +951,5 @@ public void testInsertFromFile() throws InterruptedException {
assertEquals(2, rowCount);
assertTrue(bigquery.delete(DATASET, destinationTableName));
}
*/
}

0 comments on commit 29ed5fb

Please sign in to comment.