Skip to content

Commit

Permalink
Bigtable: Deemphasize most of the settings and move them to the StubS…
Browse files Browse the repository at this point in the history
…ettings (#4509)

* Bigtable: Deemphasize most of the settings and move them to the StubSettings

This is a breaking change because it removes the ClientSettings base class. However to ease the transition, most methods have been copied over but marked deprecated to BigtableDataSettings

* format

* fix bad merge
  • Loading branch information
igorbernstein2 authored Feb 20, 2019
1 parent 9902978 commit 3559aa7
Show file tree
Hide file tree
Showing 5 changed files with 266 additions and 81 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public static BigtableDataClient create(String projectId, String instanceId) thr
* created based on the settings passed in, or defaults for any settings that are not set.
*/
public static BigtableDataClient create(BigtableDataSettings settings) throws IOException {
EnhancedBigtableStub stub = EnhancedBigtableStub.create(settings.getTypedStubSettings());
EnhancedBigtableStub stub = EnhancedBigtableStub.create(settings.getStubSettings());
return new BigtableDataClient(stub);
}

Expand Down
Loading

0 comments on commit 3559aa7

Please sign in to comment.