Skip to content

Commit

Permalink
remove todos that suggest depending on appengine artifact to get proj…
Browse files Browse the repository at this point in the history
…ectId and namespace
  • Loading branch information
Ajay Kannan committed Oct 28, 2015
1 parent 41f607d commit 38253d9
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -411,8 +411,6 @@ private static boolean isWindows() {
}

protected static String getAppEngineProjectId() {
// TODO(ozarov): An alternative to reflection would be to depend on AE api jar:
// http://mvnrepository.com/artifact/com.google.appengine/appengine-api-1.0-sdk/1.2.0
try {
Class<?> factoryClass =
Class.forName("com.google.appengine.api.appidentity.AppIdentityServiceFactory");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,6 @@ public String namespace() {
}

private static String defaultNamespace() {
// TODO(ozarov): An alternative to reflection would be to depend on AE api jar:
// http://mvnrepository.com/artifact/com.google.appengine/appengine-api-1.0-sdk/1.2.0
try {
Class<?> clazz = Class.forName("com.google.appengine.api.NamespaceManager");
Method method = clazz.getMethod("get");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,6 @@ public void testRunStructuredQuery() {
assertEquals("Dan", entity.getString("name"));
assertEquals(2, entity.properties().size());
assertFalse(results4.hasNext());
// TODO(ozarov): construct a test to verify nextQuery/pagination
}

@Test
Expand Down

0 comments on commit 38253d9

Please sign in to comment.