Skip to content

Commit

Permalink
ci: no need to check native-image-support gRPC convergence (#666)
Browse files Browse the repository at this point in the history
I found googleapis/java-shared-dependencies#665 (comment) complains old gRPC version declared by "com.google.cloud:native-image-support" (provided scope). The artifact's gRPC dependency is irrelevant to users.
  • Loading branch information
suztomo authored Apr 14, 2022
1 parent 7dd17f4 commit 9699b46
Showing 1 changed file with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,10 @@ public void testGrpcConvergence() throws Exception {
"opencensus-exporter-stats-stackdriver",
// Because grpc-gcp's gRPC version does not use version range notation, it does not
// break downstream build
"grpc-gcp"));
"grpc-gcp",
// Because native-image-support's gRPC dependency is provided scope, it does not bring
// inconsistent gRPC artifacts to users' class paths.
"native-image-support"));
}

/**
Expand Down

0 comments on commit 9699b46

Please sign in to comment.