Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpRequest class in grpc-logging-type is missing serverIp #1042

Closed
mziccard opened this issue Jun 7, 2016 · 2 comments · Fixed by #1160
Closed

HttpRequest class in grpc-logging-type is missing serverIp #1042

mziccard opened this issue Jun 7, 2016 · 2 comments · Fixed by #1160
Assignees
@mziccard
Labels
api: logging Issues related to the Cloud Logging API.

Comments

@mziccard
Copy link
Contributor

mziccard commented Jun 7, 2016 •
edited
Loading

com.google.logging.type.HttpRequest class, contained in the package:

<dependency>
  <groupId>com.google.api.grpc</groupId>
  <artifactId>grpc-logging-type</artifactId>
  <version>0.0.1</version>
</dependency>

is missing the serverIp field that is instead documented here. The field is also missing in the http_request.proto. Should the protos be updated?

/cc @garrettjonesgoogle @shinfan @filipjs
@mziccard mziccard added the api: logging Issues related to the Cloud Logging API. label Jun 7, 2016
@mziccard
Copy link
Contributor Author

mziccard commented Jun 7, 2016 •
edited
Loading

Also the cacheFillBytes field is missing (documented here) as well as the cacheLookup field (see here).

@mziccard
Copy link
Contributor Author

mziccard commented Jul 5, 2016

The proto has been updated but the latest artifact (0.0.2) seems to still miss relevant fields. @shinfan @garrettjonesgoogle any plans for an update?

This was referenced Aug 12, 2016
Merged
Merged
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore(bazel): Update WORKSPACE files for rules_gapic, gax_java, gener…
a14fa86 
…ator_java versions (#1042)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 472750037

Source-Link: googleapis/googleapis@88f2ea3

Source-Link: https://github.com/googleapis/googleapis-gen/commit/230a5588306aae18fe8f2a57f14d4039ad72c901
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjMwYTU1ODgzMDZhYWUxOGZlOGYyYTU3ZjE0ZDQwMzlhZDcyYzkwMSJ9
github-actions bot pushed a commit to yoshi-code-bot/google-cloud-java that referenced this issue Oct 6, 2022
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-storage to v2.1…
a6cbae0 
…3.0 (googleapis#1042)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-storage](https://togithub.com/googleapis/java-storage) | `2.12.0` -> `2.13.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.13.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.13.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.13.0/compatibility-slim/2.12.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.13.0/confidence-slim/2.12.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-intelligence).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTYuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxNi4wIn0=-->
github-actions bot pushed a commit to renovate-bot/google-cloud-java that referenced this issue Oct 8, 2022
@release-please
chore(main): release 2.2.13 (googleapis#1043)
cbcb2d3 
🤖 I have created a release *beep* *boop*
---


## [2.2.13](https://togithub.com/googleapis/java-video-intelligence/compare/v2.2.12...v2.2.13) (2022-10-07)


### Dependencies

* Update dependency com.google.cloud:google-cloud-core to v2.8.20 ([googleapis#1038](https://togithub.com/googleapis/java-video-intelligence/issues/1038)) ([51e1f2c](https://togithub.com/googleapis/java-video-intelligence/commit/51e1f2c6dc330f60f4b1c317ee8e10f029dfc108))
* Update dependency com.google.cloud:google-cloud-storage to v2.13.0 ([googleapis#1042](https://togithub.com/googleapis/java-video-intelligence/issues/1042)) ([a6cbae0](https://togithub.com/googleapis/java-video-intelligence/commit/a6cbae02b8831249a7f200679bdbb7ed738f55ce))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this issue Feb 1, 2023
@renovate-bot
deps: update dependency com.google.api.grpc:proto-google-iam-v1 to v1…
4c91ec0 
….6.21 (#1042)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.api.grpc:proto-google-iam-v1](https://togithub.com/googleapis/java-iam/proto-google-iam-v1) ([source](https://togithub.com/googleapis/java-iam)) | `1.6.20` -> `1.6.21` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.21/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.21/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.21/compatibility-slim/1.6.20)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.21/confidence-slim/1.6.20)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-iam</summary>

### [`v1.6.21`](https://togithub.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#&#8203;1621-httpsgithubcomgoogleapisjava-iamcomparev1620v1621-2022-11-23)

[Compare Source](https://togithub.com/googleapis/java-iam/compare/v1.6.20...v1.6.21)

##### Dependencies

-   Update dependency com.google.cloud:google-iam-policy to v1.6.20 ([#&#8203;554](https://togithub.com/googleapis/java-iam/issues/554)) ([940af38](https://togithub.com/googleapis/java-iam/commit/940af38f2b1e4ea7846d5fe2b174b5c6f8962a67))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4zMC40IiwidXBkYXRlZEluVmVyIjoiMzQuMzIuMCJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mziccard mziccard

Labels
api: logging Issues related to the Cloud Logging API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing field to Logging's HttpRequest class mziccard/gcloud-java
1 participant
@mziccard