Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skipLeadingRows is long for external tables but integer for load jobs #1044

Closed
mziccard opened this issue Jun 8, 2016 · 2 comments
Closed

skipLeadingRows is long for external tables but integer for load jobs #1044

mziccard opened this issue Jun 8, 2016 · 2 comments
Assignees
@andreamlin
Labels
api: bigquery Issues related to the BigQuery API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@mziccard
Copy link
Contributor

mziccard commented Jun 8, 2016

I believe this changed recently.

The skipLeadingRows field takes a long value when creating an external table (see docs). Instead, skipLeadingRows in load jobs takes an integer value (see docs). Why this difference? Load jobs can take files up to 5TB so in principle there is the chance that users might want to skip more than Integer.MAX_INT rows.
@mziccard mziccard added the api: bigquery Issues related to the BigQuery API. label Jun 8, 2016
@garrettjonesgoogle garrettjonesgoogle added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triaged for GA labels Aug 7, 2017
@andreamlin
Copy link
Contributor

Opened an internal changelist #170272287 to switch the API's internal proto definition for the load job skipLeadingRows to type int64.

@andreamlin
Copy link
Contributor

The types are defined by the BigQuery API, and the API producer is hesitant to change protobuf field types in case of backwards-compatibility issues.

Closing this issue for now.

github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-bigquery to v2.…
5ce52e5 
…16.0 (#1044)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-bigquery](https://togithub.com/googleapis/java-bigquery) | `2.15.0` -> `2.16.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.16.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.16.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.16.0/compatibility-slim/2.15.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.16.0/confidence-slim/2.15.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-bigquery</summary>

### [`v2.16.0`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#&#8203;2160-httpsgithubcomgoogleapisjava-bigquerycomparev2150v2160-2022-09-12)

[Compare Source](https://togithub.com/googleapis/java-bigquery/compare/v2.15.0...v2.16.0)

##### Features

-   Add preserveAsciiControlCharacters to CsvOptions ([#&#8203;2143](https://togithub.com/googleapis/java-bigquery/issues/2143)) ([856893f](https://togithub.com/googleapis/java-bigquery/commit/856893f4d8f1b419365d8f179ce9f9e571dec718))
-   Add reference file schema option for federated formats ([#&#8203;2269](https://togithub.com/googleapis/java-bigquery/issues/2269)) ([8c488e6](https://togithub.com/googleapis/java-bigquery/commit/8c488e64259bd67716342f48f96d2932c5e57c3e))

##### Bug Fixes

-   Socket-timeout at bigquery.it.ITNightlyBigQueryTest: testForTableNotFound ([#&#8203;2260](https://togithub.com/googleapis/java-bigquery/issues/2260)) ([a9b5fb2](https://togithub.com/googleapis/java-bigquery/commit/a9b5fb2c1078788ddb1ac3169c9ce597af228ac0))

##### Dependencies

-   Update dependency com.google.apis:google-api-services-bigquery to v2-rev20220827-2.0.0 ([#&#8203;2261](https://togithub.com/googleapis/java-bigquery/issues/2261)) ([3c67d21](https://togithub.com/googleapis/java-bigquery/commit/3c67d21c10f66b3c5313a1733f4e81db42c1b7c3))
-   Update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.9.3 ([#&#8203;2259](https://togithub.com/googleapis/java-bigquery/issues/2259)) ([5e30a04](https://togithub.com/googleapis/java-bigquery/commit/5e30a04e5b14b03e60e587787180b27f605d6abd))
-   Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#&#8203;2267](https://togithub.com/googleapis/java-bigquery/issues/2267)) ([8472fe5](https://togithub.com/googleapis/java-bigquery/commit/8472fe580a8197aaa3957dd3231fed0a9511fbb5))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-aiplatform).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTQuNSIsInVwZGF0ZWRJblZlciI6IjMyLjE5NC41In0=-->
github-actions bot pushed a commit that referenced this issue Sep 19, 2022
@release-please
chore(main): release 3.3.0 (#1025)
9bd4e09 
🤖 I have created a release *beep* *boop*
---


## [3.3.0](googleapis/java-aiplatform@v3.2.0...v3.3.0) (2022-09-15)


### Features

* add input_artifacts to PipelineJob.runtime_config in aiplatform v1 pipeline_job ([ff7a4ab](googleapis/java-aiplatform@ff7a4ab))
* Add model_monitoring_stats_anomalies,model_monitoring_status to BatchPredictionJob in aiplatform v1beta1 batch_prediction_job.proto ([#1041](googleapis/java-aiplatform#1041)) ([fe03c60](googleapis/java-aiplatform@fe03c60))
* Add read_mask to ListPipelineJobsRequest in aiplatform v1 pipeline_service ([#1032](googleapis/java-aiplatform#1032)) ([ff7a4ab](googleapis/java-aiplatform@ff7a4ab))
* Add UpsertDatapoints and RemoveDatapoints rpcs to IndexService in aiplatform v1 index_service.proto ([#1030](googleapis/java-aiplatform#1030)) ([4114021](googleapis/java-aiplatform@4114021))
* add UpsertDatapoints and RemoveDatapoints rpcs to IndexService in aiplatform v1beta1 index_service.proto ([4114021](googleapis/java-aiplatform@4114021))
* Add WriteFeatureValues in aiplatform v1beta1 featurestore_online_service.proto ([#1022](googleapis/java-aiplatform#1022)) ([267827e](googleapis/java-aiplatform@267827e))


### Dependencies

* Update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.18.0 ([#1021](googleapis/java-aiplatform#1021)) ([c3d34a0](googleapis/java-aiplatform@c3d34a0))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.5 ([#1016](googleapis/java-aiplatform#1016)) ([cc0af7b](googleapis/java-aiplatform@cc0af7b))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.6 ([#1026](googleapis/java-aiplatform#1026)) ([6ed66cc](googleapis/java-aiplatform@6ed66cc))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 ([#1031](googleapis/java-aiplatform#1031)) ([5adefd4](googleapis/java-aiplatform@5adefd4))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 ([#1040](googleapis/java-aiplatform#1040)) ([b6c1b20](googleapis/java-aiplatform@b6c1b20))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 ([#1044](googleapis/java-aiplatform#1044)) ([5ce52e5](googleapis/java-aiplatform@5ce52e5))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#1043](googleapis/java-aiplatform#1043)) ([40eae55](googleapis/java-aiplatform@40eae55))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#1045](googleapis/java-aiplatform#1045)) ([0f66302](googleapis/java-aiplatform@0f66302))
* Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#1015](googleapis/java-aiplatform#1015)) ([7a2fcb0](googleapis/java-aiplatform@7a2fcb0))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this issue Oct 6, 2022
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-video-in…
1eefd96 
…telligence to v2.2.12 (#1044)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-video-intelligence](https://togithub.com/googleapis/java-video-intelligence) | `2.2.10` -> `2.2.12` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-video-intelligence/2.2.12/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-video-intelligence/2.2.12/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-video-intelligence/2.2.12/compatibility-slim/2.2.10)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-video-intelligence/2.2.12/confidence-slim/2.2.10)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-intelligence).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTcuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxNy4wIn0=-->
suztomo pushed a commit that referenced this issue Feb 1, 2023
@gcf-owl-bot
chore: upgrade native image checks to graalvm-22.3.0 (#1718) (#1044)
07eff99 
chore: upgrade native image checks to graalvm-22.3.0
Source-Link: googleapis/synthtool@5e52896
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:27b1b1884dce60460d7521b23c2a73376cba90c0ef3d9f0d32e4bdb786959cfd

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreamlin andreamlin

Labels
api: bigquery Issues related to the BigQuery API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tswast @mziccard @andreamlin @garrettjonesgoogle