Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

javadoc_test CI build does not run mvn javadoc target #3461

Closed
andreamlin opened this issue Jul 12, 2018 · 0 comments
Closed

javadoc_test CI build does not run mvn javadoc target #3461

andreamlin opened this issue Jul 12, 2018 · 0 comments
Assignees
@andreamlin @garrettjonesgoogle
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@andreamlin
Copy link
Contributor

andreamlin commented Jul 12, 2018 •
edited
Loading

https://circleci.com/gh/GoogleCloudPlatform/google-cloud-java/8882?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link should have failed on making the javadoc (#3459 fixes the javadoc error)

We should ensure that the CI build for javadoc_test does indeed run the javadoc target and throw an exception if there's an error.

This is an annoying issue for when google-cloud-java is being released, and the javadoc target is actually run.
@andreamlin andreamlin added priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like. labels Jul 12, 2018
@garrettjonesgoogle garrettjonesgoogle mentioned this issue Jul 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreamlin andreamlin

@garrettjonesgoogle garrettjonesgoogle

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chingor13 @andreamlin @garrettjonesgoogle