Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Removing doclint disabling for bigtable on Java 8 #3462

Closed
wants to merge 3 commits into from
Closed

[DO NOT MERGE] Removing doclint disabling for bigtable on Java 8 #3462

wants to merge 3 commits into from

Conversation

garrettjonesgoogle
Copy link
Member

(Hopefully) Fixes #3461

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 12, 2018
@andreamlin
Copy link
Contributor

Has this been tested locally against a commit snapshot that we know has a failing javadoc target?

@garrettjonesgoogle
Copy link
Member Author

Here's the tricky thing: this will have no effect locally. The only effect it can have is on circle, where it should expose failures. I guess the only way to test is to push a commit in the PR which has a failure and make sure that it fails on Circle (where previously it passed). I'll wait for the present test run to finish before trying that out.

@andreamlin
Copy link
Contributor

Hmm, was javadoc_test supposed to fail?

@garrettjonesgoogle
Copy link
Member Author

Yes, it was supposed to fail and it didn't. Looks like this change didn't work.

@garrettjonesgoogle garrettjonesgoogle changed the title Removing doclint disabling for bigtable on Java 8 [DO NOT MERGE] Removing doclint disabling for bigtable on Java 8 Jul 12, 2018
@garrettjonesgoogle garrettjonesgoogle added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 12, 2018
@sduskis sduskis added the api: bigtable Issues related to the Bigtable API. label Oct 12, 2018
@JustinBeckwith
Copy link
Contributor

👋 @garrettjonesgoogle what's the status on this one?

@garrettjonesgoogle
Copy link
Member Author

Abandoning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreamlin andreamlin Awaiting requested review from andreamlin

@pongad pongad Awaiting requested review from pongad

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@garrettjonesgoogle @andreamlin @JustinBeckwith @sduskis @googlebot