-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In ServiceApi classes, consider creating a helper class for each resource path to get and set subvariables #397
Comments
After some internal discussion, we realized that this would increase the complexity of the surface too much. The reason is that the "old" way of passing in the String form of resource names would still to be supported, because these resource names can come from other sources, and the proto-generated classes wouldn't provide the helper classes, thus providing an inconsistent surface. Consequently, adding helper classes would only add clutter. |
This PR was generated using Autosynth. 🌈 <details><summary>Log from Synthtool</summary> ``` 2021-03-04 19:39:15,343 synthtool [DEBUG] > Executing /root/.cache/synthtool/java-resourcemanager/.github/readme/synth.py. On branch autosynth-readme nothing to commit, working tree clean 2021-03-04 19:39:16,284 synthtool [DEBUG] > Wrote metadata to .github/readme/synth.metadata/synth.metadata. ``` </details> Full log will be available here: https://source.cloud.google.com/results/invocations/5f809a70-f4a0-4457-8338-dfe283a48e40/targets - [ ] To automatically regenerate this PR, check this box.
…onfig to v1.2.5 (#397) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.2.4` -> `1.2.5` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.5/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.5/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.5/compatibility-slim/1.2.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.5/confidence-slim/1.2.4)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.2.5`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#​125-httpsgithubcomgoogleapisjava-shared-configcomparev124v125-2022-01-11) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.2.4...v1.2.5) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-workflows).
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [1.4.4](https://togithub.com/googleapis/java-accesscontextmanager/compare/v1.4.3...v1.4.4) (2022-10-03) ### Dependencies * Update dependency cachetools to v5 ([#401](https://togithub.com/googleapis/java-accesscontextmanager/issues/401)) ([5b95e04](https://togithub.com/googleapis/java-accesscontextmanager/commit/5b95e0409186acc96326cb1419749d1968d09747)) * Update dependency certifi to v2022.9.24 ([#381](https://togithub.com/googleapis/java-accesscontextmanager/issues/381)) ([2006334](https://togithub.com/googleapis/java-accesscontextmanager/commit/20063345f9b41bf9d1f8dad3c8ee5b01e3128b7c)) * Update dependency charset-normalizer to v2.1.1 ([#385](https://togithub.com/googleapis/java-accesscontextmanager/issues/385)) ([a91ee95](https://togithub.com/googleapis/java-accesscontextmanager/commit/a91ee95a4d9aa0d803e410484a2ef0bf55bef5f1)) * Update dependency click to v8.1.3 ([#386](https://togithub.com/googleapis/java-accesscontextmanager/issues/386)) ([703e69c](https://togithub.com/googleapis/java-accesscontextmanager/commit/703e69c8ea5fc2e871ee846c85558f8bcf831ae7)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#405](https://togithub.com/googleapis/java-accesscontextmanager/issues/405)) ([aa35e73](https://togithub.com/googleapis/java-accesscontextmanager/commit/aa35e73690f828d7dfe830b381a83da782650e71)) * Update dependency gcp-releasetool to v1.8.8 ([#382](https://togithub.com/googleapis/java-accesscontextmanager/issues/382)) ([f6c2f5f](https://togithub.com/googleapis/java-accesscontextmanager/commit/f6c2f5f3052b17cb553c765a2285e946bcc22889)) * Update dependency google-api-core to v2.10.1 ([#387](https://togithub.com/googleapis/java-accesscontextmanager/issues/387)) ([9040055](https://togithub.com/googleapis/java-accesscontextmanager/commit/9040055d0f96b7bf3567e4bac4010364d0058eae)) * Update dependency google-auth to v2.12.0 ([#388](https://togithub.com/googleapis/java-accesscontextmanager/issues/388)) ([6d3241c](https://togithub.com/googleapis/java-accesscontextmanager/commit/6d3241cadcfc5ac81232ae495b5207add8d9f59d)) * Update dependency google-cloud-core to v2.3.2 ([#383](https://togithub.com/googleapis/java-accesscontextmanager/issues/383)) ([d3fe01b](https://togithub.com/googleapis/java-accesscontextmanager/commit/d3fe01bc618ffe0e826c052583714524cd049928)) * Update dependency google-cloud-storage to v2.5.0 ([#389](https://togithub.com/googleapis/java-accesscontextmanager/issues/389)) ([934a05e](https://togithub.com/googleapis/java-accesscontextmanager/commit/934a05e263d1bb8b1c94d2f478bf2f15723bd6f8)) * Update dependency google-crc32c to v1.5.0 ([#390](https://togithub.com/googleapis/java-accesscontextmanager/issues/390)) ([5268cb1](https://togithub.com/googleapis/java-accesscontextmanager/commit/5268cb1a04fd9e05d950d5c03871a81e60364d2a)) * Update dependency googleapis-common-protos to v1.56.4 ([#384](https://togithub.com/googleapis/java-accesscontextmanager/issues/384)) ([32b231e](https://togithub.com/googleapis/java-accesscontextmanager/commit/32b231eef7879a6a0d74b650df878e2c462f207e)) * Update dependency importlib-metadata to v4.12.0 ([#391](https://togithub.com/googleapis/java-accesscontextmanager/issues/391)) ([3fee2e5](https://togithub.com/googleapis/java-accesscontextmanager/commit/3fee2e55869b14014c2240ce78a60c5888c7e9ae)) * Update dependency jeepney to v0.8.0 ([#392](https://togithub.com/googleapis/java-accesscontextmanager/issues/392)) ([b8a3a7f](https://togithub.com/googleapis/java-accesscontextmanager/commit/b8a3a7f6fcb6b72f95241a6e8d6b1a152c5e59b9)) * Update dependency jinja2 to v3.1.2 ([#393](https://togithub.com/googleapis/java-accesscontextmanager/issues/393)) ([47bfa73](https://togithub.com/googleapis/java-accesscontextmanager/commit/47bfa73b387eccb7450b8e0f2a19a38bf28d49f3)) * Update dependency keyring to v23.9.3 ([#394](https://togithub.com/googleapis/java-accesscontextmanager/issues/394)) ([1f01a1b](https://togithub.com/googleapis/java-accesscontextmanager/commit/1f01a1b83e4cd45bc03458ae9629e4cbe4c8deec)) * Update dependency markupsafe to v2.1.1 ([#395](https://togithub.com/googleapis/java-accesscontextmanager/issues/395)) ([7077e38](https://togithub.com/googleapis/java-accesscontextmanager/commit/7077e38a1a6c87d3449e63ce89ce3a56d696a93f)) * Update dependency protobuf to v3.20.2 ([#396](https://togithub.com/googleapis/java-accesscontextmanager/issues/396)) ([d5df519](https://togithub.com/googleapis/java-accesscontextmanager/commit/d5df519d69768a54fd02fee3251ed3fc4d9cd9b3)) * Update dependency protobuf to v4 ([#402](https://togithub.com/googleapis/java-accesscontextmanager/issues/402)) ([fe4ac2f](https://togithub.com/googleapis/java-accesscontextmanager/commit/fe4ac2f28d55d887d8618d420df310645ca29046)) * Update dependency pyjwt to v2.5.0 ([#397](https://togithub.com/googleapis/java-accesscontextmanager/issues/397)) ([dd3fa88](https://togithub.com/googleapis/java-accesscontextmanager/commit/dd3fa88e32f6b0b4abc8be4eacfd509b83bd9671)) * Update dependency requests to v2.28.1 ([#398](https://togithub.com/googleapis/java-accesscontextmanager/issues/398)) ([3e55397](https://togithub.com/googleapis/java-accesscontextmanager/commit/3e55397a817d3937b2f50bb7245eda5319d29ae6)) * Update dependency typing-extensions to v4.3.0 ([#399](https://togithub.com/googleapis/java-accesscontextmanager/issues/399)) ([d0d77e2](https://togithub.com/googleapis/java-accesscontextmanager/commit/d0d77e24179689351ddf677b012c14f94e109346)) * Update dependency zipp to v3.8.1 ([#400](https://togithub.com/googleapis/java-accesscontextmanager/issues/400)) ([c40c50e](https://togithub.com/googleapis/java-accesscontextmanager/commit/c40c50edb7767e444cf7a158df513f15e7e6f644)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [2.3.6](https://togithub.com/googleapis/java-orgpolicy/compare/v2.3.5...v2.3.6) (2022-10-05) ### Dependencies * Update dependency certifi to v2022.9.24 ([#396](https://togithub.com/googleapis/java-orgpolicy/issues/396)) ([d6e315e](https://togithub.com/googleapis/java-orgpolicy/commit/d6e315e2b3bbdd475d580ccc9fb47a5cec74dd7c)) * Update dependency charset-normalizer to v2.1.1 ([#399](https://togithub.com/googleapis/java-orgpolicy/issues/399)) ([5a17ba7](https://togithub.com/googleapis/java-orgpolicy/commit/5a17ba76cb3e340c616e13bb111d26ae2db494c6)) * Update dependency click to v8.1.3 ([#400](https://togithub.com/googleapis/java-orgpolicy/issues/400)) ([748cf9c](https://togithub.com/googleapis/java-orgpolicy/commit/748cf9c590345bb5e263bcb7048b33bf56e2009f)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#405](https://togithub.com/googleapis/java-orgpolicy/issues/405)) ([1f1768e](https://togithub.com/googleapis/java-orgpolicy/commit/1f1768e7549e436433db00ff72defa0722475267)) * Update dependency gcp-releasetool to v1.8.8 ([#397](https://togithub.com/googleapis/java-orgpolicy/issues/397)) ([8eb0c36](https://togithub.com/googleapis/java-orgpolicy/commit/8eb0c36761020ffc787de1fdbec01437d15fb592)) * Update dependency google-api-core to v2.10.1 ([#401](https://togithub.com/googleapis/java-orgpolicy/issues/401)) ([b72f9d2](https://togithub.com/googleapis/java-orgpolicy/commit/b72f9d27ec1212dc3acd5b1128efae77bcd21ff7)) * Update dependency google-auth to v2.12.0 ([#402](https://togithub.com/googleapis/java-orgpolicy/issues/402)) ([9bfcfb6](https://togithub.com/googleapis/java-orgpolicy/commit/9bfcfb61471aad457e41ec85066c2a4b1c0be8c1)) * Update dependency google-cloud-storage to v2.5.0 ([#403](https://togithub.com/googleapis/java-orgpolicy/issues/403)) ([50b5d7c](https://togithub.com/googleapis/java-orgpolicy/commit/50b5d7c5309c6ec0cd88d95736bca91e7c049759)) * Update dependency googleapis-common-protos to v1.56.4 ([#398](https://togithub.com/googleapis/java-orgpolicy/issues/398)) ([bf62b87](https://togithub.com/googleapis/java-orgpolicy/commit/bf62b872b3bb90a18f5622a7630d1e259bcc7794)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.grpc:grpc-protobuf](https://togithub.com/grpc/grpc-java) | `1.48.0` -> `1.48.1` | [![age](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-protobuf/1.48.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-protobuf/1.48.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-protobuf/1.48.1/compatibility-slim/1.48.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-protobuf/1.48.1/confidence-slim/1.48.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc/grpc-java</summary> ### [`v1.48.1`](https://togithub.com/grpc/grpc-java/compare/v1.48.0...v1.48.1) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzUuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEzNS4xIn0=-->
No description provided.
The text was updated successfully, but these errors were encountered: