-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [datalineage] new module for datalineage #8996
Conversation
Can you share the command that was used to generate the library? |
@alicejli api-name having "java-" prefix is strange. What did you run? (It's possible you specified it incorrectly or the script has a bug) I'm adding a step to record the Python command: https://github.com/googleapis/google-cloud-java/pull/8995/files#diff-a3adec6fceb9be1a8aca36549237d47cf7b51a8d414ce788a0cb6a8a5aeb7311R192 |
I ran: python3.9 generation/new_client/new-client.py generate --api_shortname=datalineage --proto-path=google/cloud/datacatalog/lineage --name-pretty="Data Lineage" --product-docs="https://cloud.google.com/data-catalog/docs/data-lineage/" --api-description="Lineage is used to track data flows between assets over time." |
Creating a fix for api-name field in OwlBot.yaml template. |
Well glad to see my newly added check is working 😅 . |
Okay, confirmed that running the script from main does generate the missing lines; I just originally created this before the template was updated. I manually added in the missing lines for this PR. |
Rerunning script for #8994 as I happened to run it right before the SNAPSHOT release PR went out.
Command to generate: