Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [datalineage] new module for datalineage #8996

Merged
merged 5 commits into from
Jan 19, 2023

Conversation

alicejli
Copy link
Contributor

@alicejli alicejli commented Jan 18, 2023

Rerunning script for #8994 as I happened to run it right before the SNAPSHOT release PR went out.

Command to generate:

python3.9 generation/new_client/new-client.py generate --api_shortname=datalineage --proto-path=google/cloud/datacatalog/lineage --name-pretty="Data Lineage" --product-docs="https://cloud.google.com/data-catalog/docs/data-lineage/" --api-description="Lineage is used to track data flows between assets over time."

@alicejli alicejli marked this pull request as ready for review January 18, 2023 18:59
@alicejli alicejli added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2023
@meltsufin
Copy link
Member

Can you share the command that was used to generate the library?

java-datalineage/.OwlBot.yaml Outdated Show resolved Hide resolved
@suztomo
Copy link
Member

suztomo commented Jan 18, 2023

@alicejli api-name having "java-" prefix is strange. What did you run? (It's possible you specified it incorrectly or the script has a bug)

I'm adding a step to record the Python command: https://github.com/googleapis/google-cloud-java/pull/8995/files#diff-a3adec6fceb9be1a8aca36549237d47cf7b51a8d414ce788a0cb6a8a5aeb7311R192

@alicejli
Copy link
Contributor Author

alicejli commented Jan 18, 2023

@alicejli api-name having "java-" prefix is strange. What did you run? (It's possible you specified it incorrectly or the script has a bug)

I'm adding a step to record the Python command: https://github.com/googleapis/google-cloud-java/pull/8995/files#diff-a3adec6fceb9be1a8aca36549237d47cf7b51a8d414ce788a0cb6a8a5aeb7311R192

I ran:

python3.9 generation/new_client/new-client.py generate --api_shortname=datalineage --proto-path=google/cloud/datacatalog/lineage --name-pretty="Data Lineage" --product-docs="https://cloud.google.com/data-catalog/docs/data-lineage/" --api-description="Lineage is used to track data flows between assets over time."

@suztomo
Copy link
Member

suztomo commented Jan 18, 2023

Creating a fix for api-name field in OwlBot.yaml template.

@suztomo
Copy link
Member

suztomo commented Jan 19, 2023

Screenshot 2023-01-19 at 9 27 08 AM

@alicejli
Copy link
Contributor Author

Screenshot 2023-01-19 at 9 27 08 AM

Well glad to see my newly added check is working 😅 .
I think I ran the original script before #8790 was merged in. Let me confirm.

@alicejli
Copy link
Contributor Author

Okay, confirmed that running the script from main does generate the missing lines; I just originally created this before the template was updated. I manually added in the missing lines for this PR.

@alicejli alicejli requested a review from suztomo January 19, 2023 15:39
@alicejli alicejli merged commit ea8d17b into main Jan 19, 2023
@alicejli alicejli deleted the new_module_java-datalineage_v2 branch January 19, 2023 18:35
@release-please release-please bot mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants