Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use api_shortname in OwlBot.yaml's api_name #8999

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Jan 18, 2023

Follow-up of #8996 (review)

When generating new OwlBot.yaml file, use api_shortname as api_name field of the file.

go/owlbot-howto

api-name: Gets inserted into pull request titles. Useful for mono-repos.

This is the command to list bad file we recently created:
find . -name '.OwlBot.yaml' |xargs grep 'api-name: java-'

When generating new OwlBot.yaml file, use api_shortname
as api_name field of the file.

This is the command to list bad file we recently created:
find . -name '.OwlBot.yaml' |xargs grep 'api-name: java-'
@suztomo suztomo requested a review from alicejli January 18, 2023 22:31
Copy link
Contributor

@alicejli alicejli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed by rerunning the script that this fixes the issue of having an extraneous java- prefix.

@alicejli alicejli merged commit ef758f9 into main Jan 20, 2023
@alicejli alicejli deleted the fix_api-name branch January 20, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants